Hi John, I'd like to resurrect this discussion as the issue hasn't been fully put to bed and as I'm preparing for 2.9 wxwidgets upgrade I'd like to figure out whether I still need to patch wxlua to support my use case.
It all started here: http://www.mail-archive.com/wxlua-users@lists.sourceforge.net/msg03002.html. Basically, you made a change long time ago (I think when the code was still in CVS) to avoid setting event handlers from coroutines, which broke some code that was working before (at least for me). We discussed this and you made a slight change (http://wxlua.svn.sourceforge.net/viewvc/wxlua?view=revision&revision=104), which made things better, but it didn't fully address the issue and some of the code I need still doesn't run. I ended up patching wxlua and removing that one line that was added in the revision 104 (line 103 in this diff: http://wxlua.svn.sourceforge.net/viewvc/wxlua/trunk/wxLua/modules/wxlua/src/wxlcallb.cpp?r1=100&r2=104&pathrev=104). I can assure you that I've been running ZeroBrane Studio on Windows, OSX, and Linux for 6+ months with that fix and have not seen or received any problem related to that change. The problem *with* the current code is easy to reproduce: take wx.dll compiled with the current (not patched) version of wxlua and put it in bin/ folder of ZBS. Try to run any of the turtle drawing examples that come with ZBS using live coding (Project | Run as Scratchpad) and the Lua process will crash. Comment out that line and it be executed correctly. I'm fine with continuing applying this patch and using my own version, but since there are people that build wxlua from the source (mostly on Linux), it would be best to come to some agreement on this change. My preference would be to remove it (note that reverting r104 is not enough as it re-introduces a different issue). If you continue to disagree, that's fine, but I'll then document the patch and update my build scripts to apply it automatically. Thank you. Paul. ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb _______________________________________________ wxlua-users mailing list wxlua-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wxlua-users
