On 9/19/2013 10:42 AM, [email protected] wrote: > # HG changeset patch > # User Deepthi Devaki <[email protected]> > # Date 1379582068 -19800 > # Node ID ff0875e85a0b5a5486537036152d228cc0ded15b > # Parent eea9154229a0aa91da16b1323d7999cfcb1cd0b7 > lookahead: fix crash for I frame cost estimation
Can you add a description of what/how to the commit message? It's harder for others to review without more details. > +#define MVC(mv) mvc[numc++] = mv; Unrelated to this patch: Should always have paren around macro definitions. > + x265_median_mv(mvp, mvc[0], mvc[1], mvc[2]); Also unrelated to patch: Wrongly prefixed function with x265_. Looks OK, but I cannot be 100% sure without some more info/context. - Derek _______________________________________________ x265-devel mailing list [email protected] https://mailman.videolan.org/listinfo/x265-devel
