On Fri, Sep 27, 2013 at 10:19 PM, Steve Borho <[email protected]> wrote:
> > > > On Fri, Sep 27, 2013 at 11:30 AM, Jean-Baptiste Kempf > <[email protected]>wrote: > >> On 27 Sep, [email protected] wrote : >> > - X265_FREE(fpelPlane); >> > + X265_FREE(fpelPlane - m_startPad); >> >> Is this always allowed? >> > > It's not robust, this if statement also needs to verify refPlane is not > NULL applyWeight() also needs to check for earlier malloc failure and > early-out. > What shall be the proper way to handle this condition in applyWeight(): when fpelPlane has no allocation. One way out is to have a flag in MotionReference object which must be set 'false' on malloc fail ('true' by default); and this flag must be checked before calling applyweight() and using the weighted pixels. But the problem with this approach will be that the condition will stay unreported. Any suggestions? Shazeb
_______________________________________________ x265-devel mailing list [email protected] https://mailman.videolan.org/listinfo/x265-devel
