On Fri, Oct 11, 2013 at 3:57 PM, Steve Borho <[email protected]> wrote:
> > > > On Fri, Oct 11, 2013 at 5:29 AM, Gopu Govindaswamy < > [email protected]> wrote: > >> # HG changeset patch >> # User Gopu Govindaswamy <[email protected]> >> # Date 1381487332 -19800 >> # Node ID 8c6bef70a1d3298d894e013ab57d070683a7d76d >> # Parent c6d89dc62e191f56f63dbcb1781a6494da50a70d >> common: included x265_param_parser to set the Input parameters to the >> encoder >> >> diff -r c6d89dc62e19 -r 8c6bef70a1d3 source/common/common.cpp >> --- a/source/common/common.cpp Fri Oct 11 01:47:53 2013 -0500 >> +++ b/source/common/common.cpp Fri Oct 11 15:58:52 2013 +0530 >> @@ -421,3 +421,142 @@ >> fprintf(stderr, "\n"); >> fflush(stderr); >> } >> + >> > > This is a public API method, so it must be extern "C" > By the way, when new methods are added to our public API (as you are about to do), we must also add them to source/x265.def.in so they are properly exported from our x265.dll. And when any breaking change is added to x265.h (like changing function arguments or adding new items to x265_param_t) we must bump X265_BUILD in source/CMakeLists.txt to prevent users from linking with a mismatched library (static or dynamic). -- Steve
_______________________________________________ x265-devel mailing list [email protected] https://mailman.videolan.org/listinfo/x265-devel
