On Wed, Oct 23, 2013 at 6:37 AM, Derek Buitenhuis <
[email protected]> wrote:

> On 10/23/2013 12:33 PM, Gopu Govindaswamy wrote:
> > (pic.poc * 3 * (width * height * pixelbytes) / 2) this statement is
> giving us wrong result if width and height is big
>
> So cast it properly instead of making a new stack variable?
>
> Or at the very least, explain that you are doing this to obtain 64-bit
> precision.
>
> A commit message saying "X is modified" with no reason as to *why* is
> completely useless.


Yeah, 4k recon dump files were busted, the commit message should mention
that.

optimally, we would use the posix file offset data type:  off_t

We would probably have to add that to our hacked stdint.h for Windows.

Also, this same fix needs to be done for the Y4M file writer

-- 
Steve Borho
_______________________________________________
x265-devel mailing list
[email protected]
https://mailman.videolan.org/listinfo/x265-devel

Reply via email to