A little more, I know *pred is readonly, and default0Save1Load2 may 1 or 2 in same loop, so *pred can safe to reuse, it reduce one memory copy.
But they in different level of function area, so we have to add a comment on loop (xRecurIntraCodingQT), for warning everyone, when they modify algorithm, don't broken *pred memory. of course, the default0Save1Load2 just to get *pred, so I like remove this parameret, we can get *pred outside of loop, then pass a pointer to readonly memory as parameter of xIntraCodingLumaBlk(). At 2014-03-07 06:36:20,chen <[email protected]> wrote: The pointer recon is unused, your patch is right But you remove m_sharedPredTransformSkip, it is temporary buffer in tskip decide path, please verify more with --tskip At 2014-03-04 18:40:23,"Satoshi Nakagawa" <[email protected]> wrote: ># HG changeset patch ># User Satoshi Nakagawa <[email protected]> ># Date 1393929339 -32400 ># Tue Mar 04 19:35:39 2014 +0900 ># Node ID 7a61566806f691ddff84cbbc42801f6c2d46df88 ># Parent 3cbde0b893e34e5770cc311d3f4b6fe064c27774 >cleanup m_sharedPredTransformSkip[] > >NEW_CALCRECON macro is TODO mark for asm experts, to optimize register >assignment.
_______________________________________________ x265-devel mailing list [email protected] https://mailman.videolan.org/listinfo/x265-devel
