On Thu, Mar 27, 2014 at 10:42 AM, Tim Walker <[email protected]> wrote: > On 27 Mar 2014, at 16:39, Derek Buitenhuis <[email protected]> wrote: > >> On 3/27/2014 1:08 PM, Tim Walker wrote: >>> FWIW, the Libav/FFmpeg wrapper already checks for return values < 0 (x265.h >>> claims x265_encoder_headers returns negative on error, even before your >>> patch). >> >> It will continue to work even with the change, indeed. >> >> - Derek > > It's actually broken right now because the function returns 0 on error, > contrary to what the documentation says.
Yep, if one of the input pointers was NULL it was returning zero. I snuck a fix for that into my patch. It sounds like it will be safe to push this, so I've queued it locally. -- Steve Borho _______________________________________________ x265-devel mailing list [email protected] https://mailman.videolan.org/listinfo/x265-devel
