On Fri, Apr 11, 2014 at 5:32 PM, dave <[email protected]> wrote: > Below is my proposed replacement for many of the H265 classes and structures > in TComSlice.h. > > All have at least basic constructor but no methods and most probably won't > need additional methods that do much more than set fields which can be added > when needed. > > A few structures have non-H265 fields that at least in HM code appear to be > useful for encoding frames. > > I have configured the classes so the Encoder class would have an instance > each H265 class so that when an object is part of multiple H265 structures, > only one instance is needed. > > Where fields are taken from either the Encoder class or x265_param I have > used references instead of copying the field or using a pointer. I don't > think this will create any concurrency issues since the fields shouldn't > need to be changed once they are set but if there are then the references > can be replaced with copies. > > I tried to setup constructors to replace init methods where applicable. > > I haven't started integrating it into x265, when everyone's happy with it I > can start replacing HM's classes with these. > > The file is also attached to this email
Hi Dave, I think the general approach is ok, and this will nicely remove about half of the remaining set/get methods left in our code. -- Steve Borho _______________________________________________ x265-devel mailing list [email protected] https://mailman.videolan.org/listinfo/x265-devel
