# HG changeset patch # User Vignesh Vijayakumar<vign...@multicorewareinc.com> # Date 1517546273 -19800 # Fri Feb 02 10:07:53 2018 +0530 # Node ID 57f5256f729bb0432ace18ba2f229d99499df24e # Parent 1ea4ca33a05c4ef26de5a07f5a36aab8a37fbc9e x86inc: Use .rdata instead of .rodata on Windows
The standard section for read-only data on Windows is .rdata. Nasm will flag non-standard sections as executable by default which isn't ideal. diff -r 1ea4ca33a05c -r 57f5256f729b source/common/x86/x86inc.asm --- a/source/common/x86/x86inc.asm Fri Feb 02 10:05:49 2018 +0530 +++ b/source/common/x86/x86inc.asm Fri Feb 02 10:07:53 2018 +0530 @@ -82,7 +82,13 @@ %endif %macro SECTION_RODATA 0-1 32 - SECTION .rodata align=%1 + %ifidn __OUTPUT_FORMAT__,win32 + SECTION .rdata align=%1 + %elif WIN64 + SECTION .rdata align=%1 + %else + SECTION .rodata align=%1 + %endif %endmacro %if WIN64
# HG changeset patch # User Vignesh Vijayakumar<vign...@multicorewareinc.com> # Date 1517546273 -19800 # Fri Feb 02 10:07:53 2018 +0530 # Node ID 57f5256f729bb0432ace18ba2f229d99499df24e # Parent 1ea4ca33a05c4ef26de5a07f5a36aab8a37fbc9e x86inc: Use .rdata instead of .rodata on Windows The standard section for read-only data on Windows is .rdata. Nasm will flag non-standard sections as executable by default which isn't ideal. diff -r 1ea4ca33a05c -r 57f5256f729b source/common/x86/x86inc.asm --- a/source/common/x86/x86inc.asm Fri Feb 02 10:05:49 2018 +0530 +++ b/source/common/x86/x86inc.asm Fri Feb 02 10:07:53 2018 +0530 @@ -82,7 +82,13 @@ %endif %macro SECTION_RODATA 0-1 32 - SECTION .rodata align=%1 + %ifidn __OUTPUT_FORMAT__,win32 + SECTION .rdata align=%1 + %elif WIN64 + SECTION .rdata align=%1 + %else + SECTION .rodata align=%1 + %endif %endmacro %if WIN64
_______________________________________________ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel
