On Tue, Dec 18, 2018 at 11:42 AM Vittorio Giovara < [email protected]> wrote:
> > > On Tue, Dec 18, 2018 at 3:07 AM Kirithika Kalirathnam < > [email protected]> wrote: > >> # HG changeset patch >> # User kirithika <[email protected]> >> # Date 1544426306 -19800 >> # Mon Dec 10 12:48:26 2018 +0530 >> # Node ID 827668cf88a85f8d14b8943c53e3f4c87196e96d >> # Parent 81373aab81dfe2e31a5ef353b1073d8bf1e22502 >> Add support for Dolby Vision profile 8.1 >> >> diff -r 81373aab81df -r 827668cf88a8 doc/reST/cli.rst >> --- a/doc/reST/cli.rst Thu Dec 13 10:55:15 2018 +0530 >> +++ b/doc/reST/cli.rst Mon Dec 10 12:48:26 2018 +0530 >> @@ -2214,7 +2214,7 @@ >> The value is specified as a float or as an integer with the profile >> times 10, >> for example profile 5 is specified as "5" or "5.0" or "50". >> >> - Currently only profile 5 enabled, Default 0 (disabled) >> + Currently only profile 5 and profile 8.1 enabled , Default 0 >> (disabled) >> >> .. option:: --dolby-vision-rpu <filename> >> >> diff -r 81373aab81df -r 827668cf88a8 source/common/param.cpp >> --- a/source/common/param.cpp Thu Dec 13 10:55:15 2018 +0530 >> +++ b/source/common/param.cpp Mon Dec 10 12:48:26 2018 +0530 >> @@ -1418,14 +1418,17 @@ >> "Invalid refine-intra value, refine-intra levels 0 to 3 >> supported"); >> CHECK(param->maxAUSizeFactor < 0.5 || param->maxAUSizeFactor > 1.0, >> "Supported factor for controlling max AU size is from 0.5 to 1"); >> - CHECK((param->dolbyProfile != 0) && (param->dolbyProfile != 50), >> - "Unsupported Dolby Vision profile, only profile 5 enabled"); >> - if (param->dolbyProfile == 50) >> + CHECK((param->dolbyProfile != 0) && (param->dolbyProfile != 50) && >> (param->dolbyProfile != 81), >> + "Unsupported Dolby Vision profile, only profile 5 and profile >> 8.1 enabled"); >> + if (param->dolbyProfile) >> { >> - CHECK((param->rc.vbvMaxBitrate < 0 && param->rc.vbvBufferSize < >> 0), "Dolby Vision requires VBV settings to enable HRD.\n"); >> - CHECK((param->sourceWidth > 3840 || param->sourceHeight > 2160), >> "Maximum supported resolution for Dolby Vision profile - 5 is 4k UHD\n"); >> - CHECK((param->internalBitDepth != 10), "Dolby Vision profile - 5 >> is Main10 only\n"); >> - CHECK((param->internalCsp != X265_CSP_I420), "Dolby Vision >> profile - 5 requires YCbCr 4:2:0 color space\n"); >> + CHECK((param->rc.vbvMaxBitrate <= 0 && param->rc.vbvBufferSize >> <= 0), "Dolby Vision requires VBV settings to enable HRD.\n"); >> > > This is still wrong, the condition should be (param->rc.vbvMaxBitrate <= 0 > && param->rc.vbvBufferSize <= 0) > copy paste fail, I meant to write "(param->rc.vbvMaxBitrate <= 0 || param->rc.vbvBufferSize <= 0)" -- Vittorio
_______________________________________________ x265-devel mailing list [email protected] https://mailman.videolan.org/listinfo/x265-devel
