On Wed, Jan 2, 2019 at 4:59 PM <[email protected]> wrote:
> # HG changeset patch > # User Radhakrishnan <[email protected]> > # Date 1546418753 -19800 > # Wed Jan 02 14:15:53 2019 +0530 > # Node ID a0e1f722d25634b9d5065d51c270a5a3d00d502c > # Parent 8f1c154aae5e3549eace74e152ab8d05179b7d8b > fix RC version string error in MinGW > > diff -r 8f1c154aae5e -r a0e1f722d256 source/CMakeLists.txt > --- a/source/CMakeLists.txt Sat Dec 29 07:21:21 2018 +0100 > +++ b/source/CMakeLists.txt Wed Jan 02 14:15:53 2019 +0530 > @@ -578,7 +578,7 @@ > > # convert X265_LATEST_TAG (ex: 0.7) and X265_TAG_DISTANCE (ex: 103) to > # @X265_VERSION_MAJOR@,@X265_VERSION_MINOR@,@X265_BRANCH_ID@ > ,@X265_TAG_DISTANCE@ > - string(REPLACE "." ";" VERSION_LIST "${X265_LATEST_TAG}") > + string(REGEX MATCHALL "([0-9]+)" VERSION_LIST "${X265_LATEST_TAG}") > I am not a fan of this fix. It removes the _RC completely making it unclear whether we are on a release candidate tag, or a real release. Is only _ the problem, or is any non-numeric character the problem? > list(GET VERSION_LIST 0 X265_VERSION_MAJOR) > list(GET VERSION_LIST 1 X265_VERSION_MINOR) > set(X265_BRANCH_ID 0) # TODO: 0 - stable, 1 - default or other > _______________________________________________ > x265-devel mailing list > [email protected] > https://mailman.videolan.org/listinfo/x265-devel >
_______________________________________________ x265-devel mailing list [email protected] https://mailman.videolan.org/listinfo/x265-devel
