On Tue, Sep 7, 2021 at 8:06 PM Pop, Sebastian <s...@amazon.com> wrote:
> +x265-devel@ mailing list > > Hi Gopi, > > > Thanks for your feedback. I will check the errors you reported. > > I will fix all the issues and re-submit the p2s patch for review. > Could you please send me the exact cmake flags and the commands you > used to run the smoke tests? > I want to make sure my testing covers the use cases you have seen failing. > You can use the smoke-tests.txt file from the test folder in the repo https://github.com/videolan/x265/blob/master/source/test/smoke-tests.txt > > I see the following cmake flags in > https://github.com/videolan/x265/blob/master/build/linux/multilib.sh#L6 > > # cmake ../../../source -DHIGH_BIT_DEPTH=ON -DMAIN12=ON > For 8bit you can set WARNINGS_AS_ERRORS=OFF, ENABLE_TESTS=ON, CHECKED_BUILD=ON, ENABLE_ASSEMBLY=ON, HIGH_BIT_DEPTH=OFF For 10bit you can set WARNINGS_AS_ERRORS=OFF, ENABLE_TESTS=ON, CHECKED_BUILD=ON, ENABLE_ASSEMBLY=ON, HIGH_BIT_DEPTH=ON > With this configuration the current code in > x265/source/common/aarch64 fails to build. > > Would it be ok to remove the code in x265/source/common/aarch64 and > submit the p2s routines working with 8bit, 10bit, and 12bit configurations? > > > On my side I cleaned up aarch64/ipfilter8.S and have it complete with all > the functions that x86_64 implements. > > I will make sure ipfilter functions pass TestBench with and without > HIGH_BIT_DEPTH before I submit the patch for review. > > > Thanks, > > Sebastian > ------------------------------ > *From:* Gopi Satykrishna Akisetty <gopi.satykris...@multicorewareinc.com> > *Sent:* Monday, September 6, 2021 12:00 AM > *To:* Pop, Sebastian > *Cc:* Liwei Wang; Siva Viswanathan; Janani T E > *Subject:* RE: [EXTERNAL] [x265] [arm64] Status and combined patch > > Hi Pop Sebastian, > Sorry for the late reply. We have been running some tests at our end and > found that the patch is failing when HIGH_BIT_DEPTH is enabled i.e > testbench is failing and also there are output changes with decoder errors > in the smoke tests for HIGH_BIT_DEPTH enabled builds. Can you check them at > your end once. > > Thanks, > Gopi. > > On Thu, Aug 19, 2021 at 2:44 AM <s...@amazon.com> wrote: > >> Hello Gopi, >> >> Please see attached the first patch of the series. >> It ports p2s function. >> Please let me know if the format of the patch is fine. >> I will submit the next patches following your guidelines. >> >> Thanks, >> Sebastian >> >> >> On 8/18/21 6:46 AM, Gopi Satykrishna Akisetty wrote: >> > Hello Pop Sebastian, >> > Thanks for the contribution of ARM64 patches. Can you resend all the >> > final patches that have been reviewed by Min Chen over the development >> > mailing list, so that it is easier to check and commit each of them >> > individually instead of one big combined patch. Please include >> > performance numbers and the specs of the test machine used in the >> > patch as part of the commit message. Also send all these patches in a >> > sequence so that it is easier to apply them and check. >> > >> > Thanks, >> > Gopi. >> > >> >>
_______________________________________________ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel
