From ac54e3ab6b5cbbd44129c2c2087dc87f963cfdea Mon Sep 17 00:00:00 2001
 From: Mr-Z-2697 <74594146+mr-z-2...@users.noreply.github.com&gt;
 Date: Mon, 12 May 2025 01:58:02 +0800
 Subject: [PATCH] Fix weighted prediction delta_chroma_offset non-conformance
 
 The calculation here is the same as final entropy coding.
 Specification says the valid range is [-512, 511].
 ---
 &nbsp;source/encoder/weightPrediction.cpp | 6 +++++-
 &nbsp;1 file changed, 5 insertions(+), 1 deletion(-)
 
 diff --git a/source/encoder/weightPrediction.cpp 
b/source/encoder/weightPrediction.cpp
 index bc842f173..fd010d032 100644
 --- a/source/encoder/weightPrediction.cpp
 +++ b/source/encoder/weightPrediction.cpp
 @@ -466,7 +466,11 @@ void weightAnalyse(Slice&amp; slice, Frame&amp; frame, 
x265_param&amp; param)
 
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;}
 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;}
 &nbsp;
 -&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;if 
(!bFound || (minscale == (1 << mindenom) &amp;&amp; minoff == 0) || 
(float)minscore / origscore &gt; 0.998f)
 +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;int 
predTemp = (128 - ((128 * minscale) &gt;&gt; (mindenom)));
 +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;int 
deltaChromaTemp = minoff - predTemp;
 +
 +&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;if 
(!bFound || (minscale == (1 << mindenom) &amp;&amp; minoff == 0) || 
(float)minscore / origscore &gt; 0.998f ||
 
+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;(plane
 &amp;&amp; (deltaChromaTemp < -512 || deltaChromaTemp &gt; 511)) )
 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;{
 
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;SET_WEIGHT(weights[plane],
 false, 1 << denom, denom, 0);
 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;}
 --&nbsp;
 2.49.0

Attachment: 0001-Fix-weighted-prediction-delta_chroma_offset-non-conf.patch
Description: Binary data

_______________________________________________
x265-devel mailing list
x265-devel@videolan.org
https://mailman.videolan.org/listinfo/x265-devel

Reply via email to