This is an automated email from the git hooks/post-receive script. x2go pushed a commit to branch master in repository x2goserver.
commit 244eab1534e37be3bab4e70636cc03e00eddd80b Author: Mihai Moldovan <[email protected]> Date: Wed Jan 10 07:03:48 2018 +0100 x2goserver/bin/x2gostartagent: add FIXME entry for the SHADREQ_USER optional parameter. No client actually uses it and it makes the whole parameter handling fragile. --- debian/changelog | 3 +++ x2goserver/bin/x2gostartagent | 3 +++ 2 files changed, 6 insertions(+) diff --git a/debian/changelog b/debian/changelog index 28bfd44..81eb62e 100644 --- a/debian/changelog +++ b/debian/changelog @@ -213,6 +213,9 @@ x2goserver (4.1.0.0-0x2go1.2) UNRELEASED; urgency=low - x2goserver/bin/x2gostartagent: pass in xinerama configuration value via environment. Doing it via an argument is just asking for trouble since we actually have optional parameters. + - x2goserver/bin/x2gostartagent: add FIXME entry for the SHADREQ_USER + optional parameter. No client actually uses it and it makes the whole + parameter handling fragile. * x2goserver.spec: - Only create session DB in x2goserver's post install script. Do use proper Requires(post) statements to make sure perl-X2Go-Server-DB and diff --git a/x2goserver/bin/x2gostartagent b/x2goserver/bin/x2gostartagent index d9a2a45..941627c 100755 --- a/x2goserver/bin/x2gostartagent +++ b/x2goserver/bin/x2gostartagent @@ -145,6 +145,9 @@ if [[ "${X2GO_STYPE}" = 'S' ]]; then SHADOW_USER="$(awk '{split($0,a,"XSHAD"); print a[2]}' <<< "${X2GO_CMD}")" SHADOW_DESKTOP="$(awk '{split($0,a,"XSHAD"); print a[3]}' <<< "${X2GO_CMD}")" + # FIXME: no client application actually passes in an additional user name. + # This is most likely redundant and confuses things (esp. since it's an + # optional parameter) needlessly. if [[ -z "${1}" ]]; then # can this line be removed? -- Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on /srv/git/code.x2go.org/x2goserver.git _______________________________________________ x2go-commits mailing list [email protected] https://lists.x2go.org/listinfo/x2go-commits
