This is an automated email from the git hooks/post-receive script.
x2go pushed a commit to branch master
in repository x2goserver.
commit c5e3ee2a64251a49196589cf5b60e4b0154d8b7e
Author: Mihai Moldovan <io...@ionic.de>
Date: Sun Nov 22 22:13:48 2020 +0100
{X2Go/Server/Agent/NX/Options.pm,x2goserver/lib/x2goupdateoptionsstring}:
update Perl critic overrides to allow the constant pragma and document it and
other overrides (unless they are self-explanatory).
---
X2Go/Server/Agent/NX/Options.pm | 6 ++++++
debian/changelog | 4 ++++
x2goserver/bin/x2goupdateoptionsstring | 6 ++++++
3 files changed, 16 insertions(+)
diff --git a/X2Go/Server/Agent/NX/Options.pm b/X2Go/Server/Agent/NX/Options.pm
index 79bb4d44..83bfb70b 100644
--- a/X2Go/Server/Agent/NX/Options.pm
+++ b/X2Go/Server/Agent/NX/Options.pm
@@ -18,7 +18,13 @@
package X2Go::Server::Agent::NX::Options;
# Disable some Perl::Critic violations.
+#
+# I like parentheses.
## no critic (ProhibitParensWithBuiltins)
+#
+# It's recommended not to use the constant pragma, but we don't want to use
+# non-core modules like Readonly.
+## no critic (ValuesAndExpressions::ProhibitConstantPragma)
use strict;
use warnings;
diff --git a/debian/changelog b/debian/changelog
index b04c120c..0cb1421a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -305,6 +305,10 @@ x2goserver (4.1.0.4-0x2go1.2) UNRELEASED; urgency=medium
functionality.
- X2Go/Server/Agent/NX/Options.pm: port modes "enum" subs to the constant
pragma to make the code more consistent with the program wrapper.
+ - {X2Go/Server/Agent/NX/Options.pm,
+ x2goserver/lib/x2goupdateoptionsstring}: update Perl critic overrides
+ to allow the constant pragma and document it and other overrides
+ (unless they are self-explanatory).
* debian/control:
+ Build-depend upon lsb-release for distro version detection.
* debian/x2goserver.manpages:
diff --git a/x2goserver/bin/x2goupdateoptionsstring
b/x2goserver/bin/x2goupdateoptionsstring
index 127bdc7d..890b541a 100755
--- a/x2goserver/bin/x2goupdateoptionsstring
+++ b/x2goserver/bin/x2goupdateoptionsstring
@@ -18,7 +18,13 @@
# 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA.
# Disable some Perl::Critic violations.
+#
+# I like parentheses.
## no critic (ProhibitParensWithBuiltins)
+#
+# It's recommended not to use the constant pragma, but we don't want to use
+# non-core modules like Readonly.
+## no critic (ValuesAndExpressions::ProhibitConstantPragma)
use strict;
use warnings;
--
Alioth's /home/x2go-admin/maintenancescripts/git/hooks/post-receive-email on
/srv/git/code.x2go.org/x2goserver.git
_______________________________________________
x2go-commits mailing list
x2go-commits@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-commits
