On Sun, Jul 17, 2011 at 21:54:57 (CEST), Mike Gabriel wrote: > Hi Reinhard, > > On So 17 Jul 2011 12:18:49 CEST Reinhard Tartler wrote: > >> - the clean rule needs work: >> - x2goserver/x2gosqlitewrapper is not deleted >> - x2goserver-extensions/.build_man2html and >> x2goserver/.build_man2html should be deleted from the branch, as >> the content is autogenerated > > fixed in Git... > >> - the wrapper itself uses a static buffer to copy the link of >> /proc/self/exe there. this makes sense, but where does BUFSIZ come >> from and how big is it? Do we have enough control over the >> buildsystem so that it doesn't for some reason gets too small? TBH, >> I'd rather go with dynamic memory allocation here. > > BUFSIZ origin in stdio.h > http://cboard.cprogramming.com/c-programming/84272-bufsiz-value.html
256 bytes sounds pretty small to me. Of course it will work on most cases, but no need to be cheap here.. -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 _______________________________________________ X2go-Dev mailing list [email protected] https://lists.berlios.de/mailman/listinfo/x2go-dev
