Hi Morty, On Fr 30 Sep 2011 10:37:03 CEST Moritz Struebe wrote:
On 2011-09-30 09:08, Mike Gabriel wrote:* what happens to stdout and stderr? What is propagated to the client/logfile/</dev/null>?The x2goserver-run-extensions script silence the sub-scripts complete. Just committed to Git. Thanks.IS this a good idea? That is no fun debugging - and maybe those scripts want to output to the session log.
We have a new command: x2gosyslog and a loglevel option in x2goserver.conf. This one should be used.
* Why always return 0? At least for pre-* it might be nice if something can fail.Hmmmm... Really depends on the use case. On the one hand you are right on the other hand failing extensions scare me. Hmmm...Well, actually I was mainly thinking of pre-start. It can be abused to implement access-control. Or you might not want to allow a new session if some service fails to start. We have fail-* to clean up already started services
Ok, put on my internal wishlist. Sounds tempting.
* What about the environment? What information do I get (client-string/version/username/remote ip)?You have the SESSION_NAME (as $1). With that the subscripts can obtain the rest (from x2golistsessions etc.).Ah ok. Maybe a pointer to that wouldn't be too bad.
In the man page? Could you?
Another thing came to mind: What about turning around the naming-sceme: start-pre start-post start-failThat way things that belong together are listed together (also thinking of tab-compleation). I am happy with the current solution, too, though.
Hmmm... too cosmetic for me right now to make an effort.
And yet another idea: What about passing "pre-start" etc as first parameter. (similar to intit.d) That way every service only needs one script and can use symlinks.
currently pre-start is second parameter, first is SESSION_NAME. Will that already do?
Cheers Morty
Cheerio, Mike -- DAS-NETZWERKTEAM mike gabriel, dorfstr. 27, 24245 barmissen fon: +49 (4302) 281418, fax: +49 (4302) 281419 GnuPG Key ID 0xB588399B mail: [email protected], http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
pgpVhSjz3i4vu.pgp
Description: Digitale PGP-Unterschrift
_______________________________________________ X2go-Dev mailing list [email protected] https://lists.berlios.de/mailman/listinfo/x2go-dev
