V Sun, 12 Feb 2012 22:48:02 +0100 Milan Knížek <[email protected]> napsáno:
> Hello, > > I get Segmentation fault when I right-click on x2godesktopsharing > icon in the system tray and choose "Activate Desktop Sharing". (Arch > Linux.) The segfault was due to non-existent "x2godesktopsharing" group in the system. This involves two matters: x Arch Linux does not allow for group names longer then 16 characters. x x2godesktopsharing should check for existence of the group and quit nicely otherwise. Since I am not a coder, I was able to solve only the first issue - patches are attached. (The debian postinst script should probably handle the original group name as well - e.g. move the members to the new group.) It would be nice if it is accepted upstream, since a similar limitation might also exist on other *nix systems. Regards, Milan -- http://www.milan-knizek.net/ About linux and photography (Czech only) O linuxu a fotografování
>From 7610a68f95cd26c24f58848490f1ba3d7f21f83e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kn=C3=AD=C5=BEek?= <[email protected]> Date: Mon, 13 Feb 2012 20:48:11 +0100 Subject: [PATCH 1/2] Fix hardcoded GROUP name to x2godesktopshare (limited by 16 chrs) --- sharetray.cpp | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sharetray.cpp b/sharetray.cpp index 586a5b5..21ac718 100644 --- a/sharetray.cpp +++ b/sharetray.cpp @@ -322,7 +322,7 @@ void ShareTray::slotStartSharing() if ( serverSocket->listen ( socketFname ) ) { - chown ( socketFname.toAscii(),getuid(),getgrnam ( "x2godesktopsharing" )->gr_gid ); + chown ( socketFname.toAscii(),getuid(),getgrnam ( "x2godesktopshare" )->gr_gid ); QFile::setPermissions ( socketFname, QFile::ReadOwner|QFile::WriteOwner|QFile::ReadGroup|QFile::WriteGroup ); connect ( serverSocket,SIGNAL ( newConnection() ), -- 1.7.9
>From 2b25d96d2b552eb342ed3fb56fb2d8b372f0f73b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Milan=20Kn=C3=AD=C5=BEek?= <[email protected]> Date: Mon, 13 Feb 2012 20:50:19 +0100 Subject: [PATCH 2/2] Fix GROUP name in debian postinst script to x2godesktopshare --- debian/x2godesktopsharing.postinst | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/debian/x2godesktopsharing.postinst b/debian/x2godesktopsharing.postinst index 6fd8a1a..4e0b277 100755 --- a/debian/x2godesktopsharing.postinst +++ b/debian/x2godesktopsharing.postinst @@ -22,10 +22,10 @@ set -e case "$1" in configure) - X2GOGRP=`getent group | grep x2godesktopsharing || true` + X2GOGRP=`getent group | grep x2godesktopshare || true` if [ "x$X2GOGRP"="x" ] then - addgroup --system x2godesktopsharing + addgroup --system x2godesktopshare fi ;; -- 1.7.9
_______________________________________________ X2Go-Dev mailing list [email protected] https://lists.berlios.de/mailman/listinfo/x2go-dev
