Hi Mihai,

On  Sa 21 Jun 2014 23:35:26 CEST, Mihai Moldovan wrote:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

* On 21.06.2014 11:23 pm, Mike Gabriel wrote:
Hi Mihai,

On  Sa 21 Jun 2014 23:12:59 CEST, Mihai Moldovan wrote:

Multiple endiannes issues were setting incorrect event masks when creating and
drawing X11 windows.

This time, a smaller integer has been casted to a bigger one and passed to some
function actually setting its value.

This meant, that garbage from stack was attached to the smaller integer value,
putting unknown memory into the lower bytes of the bigger integer.

Fix this by creating a big, initialized temporary variable, let the function do its magic on that one and pass the value back to the smaller variable -- and cross your fingers the smaller variable can hold it without overrunning. (The last bit is a design issue we can't really fix and has been around even before
this patch.)


This fixes window creation and redrawing/updating issues on Big Endian 64bit
systems.

Fixed patch included. However, unfortunately I forgot to rebase before pushing...

Thanks, Mike!

Unfortunately the "057_nx-X11-bigendian-ppc64-no-session-window.full.patch"
description is still the "old" one. Mind updating that?

Done.

Mike
--

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: [email protected], http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

Attachment: pgpC_F4Hj3eo_.pgp
Description: Digitale PGP-Signatur

_______________________________________________
x2go-dev mailing list
[email protected]
http://lists.x2go.org/listinfo/x2go-dev

Reply via email to