Hi Salvador, On Fr 29 Mai 2015 18:18:56 CEST, Salvador Fandiño wrote:
See the commit message on the attached patch for the details.This is a minimal version introducing as few changes as possible in the nx-libs code.
thanks for sending in your patch. Can you do this: Clone https://github.com/ArcticaProject/nx-libs [Switch to (default) branch 3.6.x.]Rebase your patch against that branch (which is probably zero work, because the 3.5.0.x branch and the 3.6.x branch don't differ that much concerning nxcomp).
File a pull request (PR) on Github against the 3.6.x branch.The patch won't be accepted for 3.5.0.x, if we will include it in 3.6.x needs some discussion (at our X2Go Gathering, I suggest, or earlier on IRC).
In general, I want to have Unix file socket support in NX rather sooner than later (also for the nxproxy <-> nxproxy/nxagent) connection itself, so I am in favour of shipping this patch already in 3.6.x and not postponing it until 3.7.x. But we should reach a consensus with the other devs.
Also, the channels in NX are not used in X2Go and will neither be used in Arctica, so you patch will not affect either product that much.
Once you have filed the pull request on Github, I will start reviewing the patch. That won't be before Wednesday, though (due to some non-IT activity of mine).
Best, Mike -- DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby fon: +49 (1520) 1976 148 GnuPG Key ID 0x25771B31 mail: [email protected], http://das-netzwerkteam.de freeBusy: https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
pgpxR3CzDHyS1.pgp
Description: Digitale PGP-Signatur
_______________________________________________ x2go-dev mailing list [email protected] http://lists.x2go.org/listinfo/x2go-dev
