Hi, it looks fine for me. @Mihai, Mike DePaulo: Can we update our build environment to build x2goclient with Qt5 on platforms where Qt5 is available?
regards, Alex PS: thank you for the patch, Sébastien Am 21.03.2016 um 16:48 schrieb Mike Gabriel: > Hi Stefan, hi Mihai, hi Alex, hi Sébastien, > > On Mo 21 Mär 2016 15:13:24 CET, Sébastien Ducoulombier wrote: > >> Hello, >> >> >> Attached is a patch for X2Go Client so to support Qt5. >> >> It compiles and executes fine on Debian. >> >> I attempted to retain Qt4 compatibility using #ifdefs. >> >> >> -- >> Sébastien > > @Sébastien: Awesome job!!! Well done! > > @Alex: I'd highly recommend applying this patch, testing it and > switching the complete build to Qt5 on recent distros. Debian will > remove Qt4 support for Debian 9. At least the security and release teams > tries to each this. Qt4 is highly deprecated in the various distro realms. > > Mike > > > _______________________________________________ > x2go-dev mailing list > [email protected] > http://lists.x2go.org/listinfo/x2go-dev > -- ----------------------------------------------------------- Oleksandr Shneyder | Email: [email protected] phoca GmbH | Tel. : 0911 - 14870374 0 Harzstr. 4 | Fax. : 0911 - 14870374 9 D-90491 Nürnberg | Mobil: 0163 - 49 64 461 Geschäftsführung: Dipl.-Inf. Oleksandr Shneyder Amtsgericht München | http://www.phoca-gmbh.de HRB 196 658 | http://www.x2go.org USt-IdNr.: DE281977973 -----------------------------------------------------------
signature.asc
Description: OpenPGP digital signature
_______________________________________________ x2go-dev mailing list [email protected] http://lists.x2go.org/listinfo/x2go-dev
