Hi, I'd like to have a go at bug fixing, tidying up and adding features to the x2goClient and to start with I have spent a bit of time looking at the sessionbutton code to try to get to know it a bit. Having done so I think it would be useful to submit some refactoring patches. Once I've done this, I would then like to take the same approach with some of the other classes (onmainwindow being the next obvious candidate)
This is the sort of thing that I can imagine isn't high priority for the core devs but it will, I think, make future improvements much easier to code, review and test. I don't want to stand on any toes so thought I would ask the following before submitting anything... 1: Is the above proposal acceptable? 2: If so is there a particular approach you would like me to take? (my plan is to start by extracting code into smaller functions in a series of small commits) 3: Do the dev team have any other thoughts/suggestions as to things they would like to see as part of a refactoring that I might be able to pick up Just to be clear, to start with my intention is to make the code easier to understand and follow without changing any functionality. Cheers Dave
_______________________________________________ x2go-dev mailing list x2go-dev@lists.x2go.org https://lists.x2go.org/listinfo/x2go-dev