curcuru 01/08/14 08:01:37
Modified: test/java/src/org/apache/qetest XMLFileLogger.java
Log:
Supply default logFile name if none given; convert to absolute path
to better ensure parent directory creation
Credit: garyp
Revision Changes Path
1.8 +17 -14
xml-xalan/test/java/src/org/apache/qetest/XMLFileLogger.java
Index: XMLFileLogger.java
===================================================================
RCS file:
/home/cvs/xml-xalan/test/java/src/org/apache/qetest/XMLFileLogger.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- XMLFileLogger.java 2001/06/20 12:20:53 1.7
+++ XMLFileLogger.java 2001/08/14 15:01:37 1.8
@@ -77,7 +77,7 @@
* Logger that saves output to a simple XML-format file.
* @todo improve escapeString so it's more rigorous about escaping
* @author [EMAIL PROTECTED]
- * @version $Id: XMLFileLogger.java,v 1.7 2001/06/20 12:20:53 curcuru Exp $
+ * @version $Id: XMLFileLogger.java,v 1.8 2001/08/14 15:01:37 curcuru Exp $
*/
public class XMLFileLogger implements Logger
{
@@ -279,9 +279,10 @@
* Opens a FileWriter for our output, and logs Record format:
* <pre><resultfile fileName="<i>name of result file</i>"></pre>
*
- * NEEDSDOC @param p
+ * If no name provided, supplies a default one in current dir.
*
- * NEEDSDOC ($objectName$) @return
+ * @param p Properties block to initialize from
+ * @return true if we think we initialized OK
*/
public boolean initialize(Properties p)
{
@@ -292,25 +293,27 @@
if ((fileName == null) || fileName.equals(""))
{
-
- // We don't have a valid file, so bail
- error = true;
- ready = false;
-
- System.err.println("XMLFileLogger.initialize() ERROR: "
- + OPT_LOGFILE + " is blank");
-
- return false;
+ // Make up a file name
+ fileName = "XMLFileLogger-default-results.xml";
+ loggerProps.put(OPT_LOGFILE, fileName);
}
- // Create a file and ensure it has a place to live
+ // Create a file and ensure it has a place to live; be sure
+ // to insist on an absolute path for later parent path creation
reportFile = new File(fileName);
+ try
+ {
+ reportFile = new File(reportFile.getCanonicalPath());
+ }
+ catch (IOException ioe1)
+ {
+ reportFile = new File(reportFile.getAbsolutePath());
+ }
// Note: bare filenames may not have parents, so catch and ignore
exceptions
try
{
File parent = new File(reportFile.getParent());
-
if ((!parent.mkdirs()) && (!parent.exists()))
{
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
