http://nagoya.apache.org/bugzilla/show_bug.cgi?id=2698 *** shadow/2698 Thu Jul 19 14:37:41 2001 --- shadow/2698.tmp.12103 Thu Jul 19 14:37:41 2001 *************** *** 0 **** --- 1,39 ---- + +============================================================================+ + | Code cleanup in TreeWalker2Result.startNode() | + +----------------------------------------------------------------------------+ + | Bug #: 2698 Product: XalanJ2 | + | Status: NEW Version: CurrentCVS | + | Resolution: Platform: All | + | Severity: Minor OS/Version: All | + | Priority: Other Component: org.apache.xalan.transf | + +----------------------------------------------------------------------------+ + | Assigned To: [EMAIL PROTECTED] | + | Reported By: [EMAIL PROTECTED] | + | CC list: Cc: | + +----------------------------------------------------------------------------+ + | URL: | + +============================================================================+ + | DESCRIPTION | + Line numbers are with respect to revision 1.11. I've added this item so that it + can be tracked. I haven't found any errant behavior caused by the current code. + But it should be cleaned up. + + At line 150, we have + + if (DTM.ELEMENT_NODE == m_dtm.getNodeType(node)) + + this begins an if block. Inside there at line 167, we have + + if (DTM.ELEMENT_NODE == m_dtm.getNodeType(node)) + + This inner if test just be eliminated and the code left where it is (so that it + is in the block in which the second if is currently contained). + + Second, on line 169 we declare + + boolean hasNSDecls = false; + + This is later tested but never changed. Shouldn't the body of the loop + at line 174 maybe set this to true? Or should the whole thing be removed? + + Gary
