>> Gary wrote:
>> I didn't want to change the build.xml file without talking to someone
>> first. The fix here would be to use the same build file but add a
>> 'target="1.1"' attribute onto each javac element...
>> Because the "-target 1.1" option verifies that the build will run on JDK
>> 1.1. Without it, the compiler assumes you'll be running under the same
>> JDK as the compiler.
>
> Scott wrote:
> Sounds good to me. But will it really catch all the problems that could
> occur when building under 1.1.x? It seems we should still do a 1.1.x
> compile just to check before we release a non-developers version. (i.e.
I
> think it should still compile under 1.1.x if possible).
Ah-ha - I agree with Scott. My point was that I'd like to see Xalan both
*compile* and run under 1.1, not just run under 1.1. I suppose adding the
-target is a good idea anyway, since this theoretically ensures that we can
run under 1.1 (although as a tester I'm still planning to run a set of
tests under the actual 1.1.8 environment anyway). But for the time being
we need to occasionally actually compile with a real 1.1 era JDK to ensure
the compilation will also work. If it will help, we can add extra javac
steps to the compile target (to break up into smaller chunks); they won't
hurt any other environments and sometimes that helps the 1.1 compiler
figure out what to do.
If there's an easy way to add the extra ignores to Ant, let us know and we
should check it in. I don't use cvs edit so I forgot about the base/
files. I do occasionally have the .#*blah cvs files, but rarely enough
that I never thought to exclude them everywhere.
> Scott wrote:
> In addition to passing -mx64m in build.bat, these changes seem to get me
a
> clean build with 1.1.8.
You can always just set JAVA_OPTS in your environment, and this will get
passed along by build.bat for you.
- Shane
