RE: cvs commit: xml-xalan/java/src/org/apache/xalan/xsltc/compiler XslAttribute.java

[G. Todd Miller - XML Tech Ctr - Development]

Thanks for the warning- don;t worry, we are looking into this more.
The fix as you submitted it does fix the immediate bug, and the fix
does not introduce any regressions in our test suite. Thanks again
for the fix and the input, it is really appreciated.

Thanks,

Todd Miller

        >>Mailing-List: contact [EMAIL PROTECTED]; run by ezmlm
        >>list-help: <mailto:[EMAIL PROTECTED]>
        >>list-unsubscribe: <mailto:[EMAIL PROTECTED]>
        >>list-post: <mailto:[EMAIL PROTECTED]>
        >>Delivered-To: mailing list [EMAIL PROTECTED]
        >>From: "Gunnlaugur Thor Briem" <[EMAIL PROTECTED]>
        >>To: <[EMAIL PROTECTED]>
        >>Subject: RE: cvs commit: 
xml-xalan/java/src/org/apache/xalan/xsltc/compiler XslAttribute.java
        >>MIME-Version: 1.0
        >>Content-Transfer-Encoding: 7bit
        >>X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
        >>
        >>Hi Todd,
        >>
        >>I suspect that this fix is insufficient. It corrects
        >>the error in the case of an xsl:copy-of preceding the
        >>xsl:attribute, but I suspect the error will still be
        >>raised if the xsl:attribute is preceded by, for
        >>instance, an xsl:call-template to a template that
        >>only adds an attribute. More cases may exist, and I'm
        >>not familiar enough with the design to anticipate them
        >>at first glance, so you or Morten should probably
        >>figure out all the cases. All this code is allowed to
        >>do is eliminate any case where a non-attribute node is
        >>*definitely* going to be added to the result tree before
        >>the xsl:attribute. In any "maybe" cases, this code must
        >>not do _ignore = true (instead the determination must
        >>be left to runtime operation).
        >>
        >>Right?
        >>
        >>      - Gulli
        >>
        >>
        >>
        >>> -----Original Message-----
        >>> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
        >>> Sent: 6. september 2001 15:10
        >>> To: [EMAIL PROTECTED]
        >>> Subject: cvs commit: 
xml-xalan/java/src/org/apache/xalan/xsltc/compiler
        >>> XslAttribute.java
        >>> 
        >>> 
        >>> tmiller     01/09/06 08:10:19
        >>> 
        >>>   Modified:    java/src/org/apache/xalan/xsltc/compiler 
XslAttribute.java
        >>>   Log:
        >>>   bug fix 3320, gunnlaugur briem's fix
        >>>   
        >>>   Revision  Changes    Path
        >>>   1.10      +3 -2      
xml-xalan/java/src/org/apache/xalan/xsltc/compiler/XslAttribute.java
        >>>   
        >>>   Index: XslAttribute.java
        >>>   
===================================================================
        >>>   RCS file: 
/home/cvs/xml-xalan/java/src/org/apache/xalan/xsltc/compiler/XslAttribute.java,v
        >>>   retrieving revision 1.9
        >>>   retrieving revision 1.10
        >>>   diff -u -r1.9 -r1.10
        >>>   --- XslAttribute.java     2001/08/08 10:57:05     1.9
        >>>   +++ XslAttribute.java     2001/09/06 15:10:19     1.10
        >>>   @@ -1,5 +1,5 @@
        >>>    /*
        >>>   - * @(#)$Id: XslAttribute.java,v 1.9 2001/08/08 10:57:05 morten 
Exp $
        >>>   + * @(#)$Id: XslAttribute.java,v 1.10 2001/09/06 15:10:19 tmiller 
Exp $
        >>>     *
        >>>     * The Apache Software License, Version 1.1
        >>>     *
        >>>   @@ -60,7 +60,7 @@
        >>>     * @author Santiago Pericas-Geertsen
        >>>     * @author Morten Jorgensen
        >>>     * @author Erwin Bolwidt <[EMAIL PROTECTED]>
        >>>   - *
        >>>   + * @author Gunnlaugur Briem <[EMAIL PROTECTED]>
        >>>     */
        >>>    
        >>>    package org.apache.xalan.xsltc.compiler;
        >>>   @@ -130,6 +130,7 @@
        >>>         // The output handler will generate an error if not (at 
runtime)
        >>>         if (item instanceof If) continue;
        >>>         if (item instanceof Choose) continue;
        >>>   +     if (item instanceof CopyOf) continue;  // bug fix 3320, g. 
briem
        >>>         _ignore = true;
        >>>         reportWarning(this, parser, ErrorMsg.ATTROUTS_ERR, name);
        >>>         return;
        >>>   
        >>>   
        >>>   
        >>> 
        >>> 
---------------------------------------------------------------------
        >>> To unsubscribe, e-mail: [EMAIL PROTECTED]
        >>> For additional commands, e-mail: [EMAIL PROTECTED]
        >>> 

=======================================================================
G. Todd Miller                        Sun Microsystems Computer Company
Software Systems Engineer             2 Network Drive, MS UBUR02-201
GE&IS XML Tech Center                 Burlington, MA 01803-0903
                                      781 442-0176
                                      781 442-1437 (fax)
                                      [EMAIL PROTECTED]