Yes, this should probably set the flag and call the freeUnused()
method. The final modifier does seem a bit odd, maybe a typo
on my part.
Remember, before implementing a change to the data structure
for the new SQL Document, we need to post a message to the
group allowing a public review of the new format. i.e. A request
for comment
Regards
John G
[EMAIL PROTECTED] wrote:
I'm back... well almost - hopefully next week I will be able to get back into the SQL extension library enhancements.
I was just looking at some code, in particular I was looking at the DefaultConnectionPool. How can this pool be enabled (for an external connection pool)? The function that I would assume would set it to enabled (active) looks like (from current CVS):
/**
* The Pool can be Enabled and Disabled. Disabling the pool
* closes all the outstanding Unused connections and any new
* connections will be closed upon release.
* @param flag Control the Connection Pool. If it is enabled then Connections will actuall be held
* around. If disabled then all unused connections will be instantly closed and as
* connections are released they are closed and removed from the pool.
* @return
*/
public void setPoolEnabled( final boolean flag )
{}
Shouldn't this do something useful, like setting m_IsActive to the value of flag? It is declared as (private boolean m_IsActive = false;) and I do not see anything else that would change it.
It is a bit late, so maybe I am missing something...
...Like for example I just noticed that the flag parameter is final... what does a final parameter mean? Is this a subtle way of saying that if you want an external connection pool, you need to code your own (or at least extend from DefaultConnectionPool and replace setPoolEnabled()).
Art
--
--------------------------------------
John Gentilin
Eye Catching Solutions Inc.
18314 Carlwyn Drive
Castro Valley CA 94546
Contact Info
[EMAIL PROTECTED]
Ca Office 1-510-881-4821
NJ Office 1-732-422-4917
