Hi Ramesh,
I've reviewed your changes, and have applied them to the MAIN branch.
Thanks for all of the work you did on this.
Thanks,
Henry
------------------------------------------------------------------
Henry Zongaro Xalan development
IBM SWS Toronto Lab Tie Line 969-6044; Phone (905) 413-6044
mailto:[EMAIL PROTECTED]
Ramesh Mandava <[EMAIL PROTECTED]>
01/09/2003 03:01 PM
Please respond to xalan-dev
To: [EMAIL PROTECTED]
cc: [EMAIL PROTECTED]
Subject: [Code Bundle-1]Re: [Proposal] Using ListResourceBundle ( for
I18N/L10N )
in all Xalan packages/ Donation of code and localized messages for Xalan
[ Note: As there is limit on the mail size for sending it on this alias
I am
sending the contents in separate mails.
This is mail-1 and contains
1) patch file for existing files src-patch.diff
2) list of files which were affected outside of "res" directories
3) xpath-res.jar [ localized files and contents in
org.apache.xml.utils.res ] ]
Hi:
It seems that nobody have objection for using ListResourceBundle
instead of
property files for doing I18N/L10N of Xalan.
I am attaching the updated files including the localized files for the
message strings until Xalan 2.4.1 release.
I also updated the keys to be meaningful strings after defining the
static
constants as Strings. With this the constant strings are directly the keys
into
the contents array and we don't need to have one method call to have
conversion
from integer id to String key.
This is more clearer to understand. And other advantage is that we
don't
need to worry about keeping the MAX_CODE and MAX_WARNINGS in sync whenver
we are
updating new messages. With the previous way if somebody miss
updating
these values, then eventhough content Array has the localized message, we
maynot
be able to use those messages.
I am attaching the affected files list ( affected-xalan-files.txt),
where
error and warn methods were assuming "int" value for message code before
to
"String" value now. These files are outside "res" directories of
xalan/xpath/xml.
Can somebody review the contents and update the codebase.
Thanks
-Ramesh
>Date: Tue, 3 Dec 2002 09:42:06 -0800 (PST)
>From: Ramesh Mandava <[EMAIL PROTECTED]>
>Subject: [Proposal] Using ListResourceBundle ( for I18N/L10N ) in all
Xalan
packages/ Donation of code and localized messages for Xalan
>To: [EMAIL PROTECTED]
>Cc: [EMAIL PROTECTED]
>MIME-Version: 1.0
>Content-MD5: QqgvWcPEXsiEvTXEkCoySg==
>
>Hi,
>
> Sun Microsystems is willing to donote the translated localized
messages ( 9
>languages +
>English) for Xalan. These translated messages are also part of JDK which
Sun
>ships. This is done using ListResource bundle and standard property
lookup.
>
> Right now Xalan uses ListResourceBundle for xml/util packages and for
xalan
>and xpath packages it uses PropertyResourceBundle. It would be better if
all
the
>parts of Xalan uses the standard ListResource Bundle mechanism. This
should
>reduce customization ( of messages in GUI/ Non GUI environment ) quite a
lot
and
>will enable every developer of Xalan to use I18n'ed and l10n'ed code
out-of-box.
>
> Proposal:
> -Use ListResourceBundle for all I18N/L10N of all Xalan pacakages
> -Keep the Key Names same as we have them
>
> As the proposal is to keep the Keys same as we have now, there won't be
much
>impact of this change.
>
> What do we need from you ?
>
> - Feedback about how does it affect your application, if at all.
>
>
> If we have agreement on using ListResourceBundle all around, then Sun
can
>contribute the needed code and localized messages in 9 languages apart
from
>English.
>
> Thanks
> -Ramesh
>
>
------------- End Forwarded Message -------------
[Inline patch removed: HZ]
#### xml-res.jar has been removed from this note on January 09 2003 by
Henry Zongaro
