Re: Factory questions: proposal: use factory.createTypedNode(id) instead

[Lionel Villard]

Yep sound good for me. I'll do that.



                                                                                       
                                       
                      Shane                                                            
                                       
                      Curcuru/Cambridge        To:       [EMAIL PROTECTED]      
                                       
                      /IBM@Lotus               cc:       Lionel 
Villard/Watson/IBM@IBMUS                                      
                                               Subject:  Re: Factory questions: 
proposal: use factory.createTypedNode(id)     
                      02/06/2003 01:59          instead                                
                                       
                      PM                                                               
                                       
                      Please respond to                                                
                                       
                      xalan-dev                                                        
                                       
                                                                                       
                                       




Here's a proposal for the nodeFactory: why not have it have a set of
createTypeXNode(id) for the common node types?  This would eliminate the
casts needed and make the create methods simpler.

Since we have a reasonably bounded set of AST nodes we're actually going
to be using (the max number driven from the spec's grammar), why not just
define the factory to have creation methods for each type, plus one
'fallback' createNode(id) method for future expansion or less-frequently
used node types.

A minor point, but it could be a little bit faster and seems like it would
make implementing the Xalan factory impl a little bit easier as well.  Or
am I missing something fundamental here?

- Shane