Hi Brian,
This seems fine, although I suspect you're going to run into some issues:
1. The "transform" member functions all return int, which isn't
appropriate if exceptions will be thrown, so abstractions and virtual
functions won't make much sense.
2. All of the "transform" calls bottle-necked into "doTransform" to reduce
code redundancy. Your changes will make it more difficult to factor out
redundant code.
3. There are multiple places where exceptions are caught for other
functionality, so maybe there is more code duplication we can remove.
I'm wondering if the best way to model all of this is a base and child
class, or something more complex like:
XalanTransformerBase
/ \
XalanTransformer XalanTransformerEx
The reason the public members of XalanTransformer aren't virtual is
because it's not really designed with extensibility in mind.
Thanks!
Dave
Brian Quinlan <[EMAIL PROTECTED]>
01/11/2005 07:59 AM
Please respond to xalan-dev
To: [email protected]
cc: (bcc: David N Bertoni/Cambridge/IBM)
Subject: Proposed changes to XalanTransformer
Would it be possible (and I am volunteering to do the changes) to
refactor the XalanTransformer class into parent and child classes? The
parent class (call it XalanTransformerImpl for now) would allow all
exceptions to pass while XalanTransformer would simple call its parent's
methods and catch any exceptions. Sibling classes would also class. Any
opinions?
Also, is there any reason why the methods in XalanTransformer cannot be
made virtual?
Cheers,
Brian
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
