[ 
http://issues.apache.org/jira/browse/XALANJ-1937?page=comments#action_60080 ]
     
Brian Minchau commented on XALANJ-1937:
---------------------------------------

I have reviewed the patch, and it looks good to me.

I initially had concerns about the http link for the open issue query.  Part of 
the attached patch changes resources.xml, and the link to list open JIRA issues 
against XalanJ2 would turn into:

http://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&mode=hide&pid=10584&resolutionIds=-1&sorter/field=updated&sorter/order=DESC

The parameters passed on the end of this URL are:
rest=true
mode=hide
pid=10584
resolutionIds=-1
sorter/field=updated
sorter/order=DESC

I had a concern about the resolutionIds value. resolutionIds=1 is for Open 
issues, but resoutionIds=-1 seems to be for issues that are not closed, which 
is different and probably better looking at issues that are only in "Open" 
status.

Patch looks good.


> Apache xml.apache.org website points to bugzilla, not JIRA
> ----------------------------------------------------------
>
>          Key: XALANJ-1937
>          URL: http://issues.apache.org/jira/browse/XALANJ-1937
>      Project: XalanJ2
>         Type: Task
>   Components: Documentation
>     Reporter: Brian Minchau
>     Assignee: Sarah McNamara
>  Attachments: XALANJ-1937.diff.txt
>
> The web page //http://xml.apache.org/xalan-j/readme.html#bugs points to 
> bugzilla. This page should be updated to point to JIRA.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to