Brian, I would be glad to try the new patch, but unfortunately my temporary environment does not have facilities for easy and reliable application of diff patches. And I could not find the new files in the CVS... And the last nightly build I could find is of 2003-09-09 ...
Is it possible to get the full patched files somehow? Regarding your comments of http://issues.apache.org/jira/browse/XALANJ-2087#action_12312946 : - I like you new approach in general; it is definitely more consistent than before; - if you feel not entirely satisfied due to possibly undefined behavior of String.getBytes() (and mention that you find something attractive in my approach) then I feel I should say I can't agree that it brings in any dependency on 1.4. I believe that conditional Class.forName(...) made for appropriate platform-dependent class does not bring any platform dependency but rather helps to avoid it... Perhaps this needs some sophistication for J2EE class loading mechanisms (that I'm not an expert in), but the idea is the same... Please tell me if I am wrong. - it seems that traces of LastPrintable are still retained in the Encodings.properties - the last column is still in place... Is it intended? My best regards, Sergey Ushakov ----- Original Message ----- From: "Brian Minchau (JIRA)" <[email protected]> To: <[EMAIL PROTECTED]> Sent: Wednesday, June 08, 2005 2:10 AM Subject: [jira] Commented: (XALANJ-832) Cannot produce consistent XML for "windows-1251" encoding > [ http://issues.apache.org/jira/browse/XALANJ-832?page=comments#action_1231294 9 ] > > Brian Minchau commented on XALANJ-832: > -------------------------------------- > > Sergey, there is now a patch in XALANJ-2087 that you should try out. I've tried it out on your testcase, and it works for me. I'll be resolving this as a duplicate of that issue. > > > > Cannot produce consistent XML for "windows-1251" encoding > > --------------------------------------------------------- > > > > Key: XALANJ-832 > > URL: http://issues.apache.org/jira/browse/XALANJ-832 > > Project: XalanJ2 > > Type: Bug > > Components: Xalan > > Versions: 2.2.0 > > Environment: Operating System: Windows NT/2K > > Platform: PC > > Reporter: Sergey Ushakov > > Assignee: Brian Minchau > > Attachments: Encodings.java.1, Encodings.java.2, Encodings.properties > > > > I use Xalan 2.2.0 as DOM-to-XML serializer. > > My wish is to get output encoded as "windows-1251", but I could only get two > > different inconsistent results: > > 1. Desired output encoding in the output with wrong encoding declaration in > > the XML header: > > <?xml version="1.0" encoding="UTF-8"?> > > 2. The desired encoding declaration in the header with this encoding being > > really absent in the output (all non-ascii output goes as &#NNNN;): > > <?xml version="1.0" encoding="windows-1251"?> > > <root><child>Это > > тест</child></root> > > The Java code fragment is: > > TransformerFactory tFactory = TransformerFactory.newInstance (); > > Transformer transformer = tFactory.newTransformer (); > > // transformer.setOutputProperty (OutputKeys.ENCODING, "windows-1251"); > > DOMSource source = new DOMSource (document); > > FileOutputStream fos = new FileOutputStream ("E:\\test.xml"); > > OutputStreamWriter out = new OutputStreamWriter (fos, "windows-1251" ); > > StreamResult result = new StreamResult (out); > > transformer.transform (source, result); > > With commented line remaining commented I get result #1, with uncommented - > > result #2. > > My environment is: > > - Windows 2000 Prof with Russian locale > > - JDK 1.3.1_01 > > Regards, > > Sergey Ushakov > > -- > This message is automatically generated by JIRA. > - > If you think it was sent incorrectly contact one of the administrators: > http://issues.apache.org/jira/secure/Administrators.jspa > - > For more information on JIRA, see: > http://www.atlassian.com/software/jira > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
