[ 
http://issues.apache.org/jira/browse/XALANJ-2113?page=comments#action_12315859 
] 

Brian Minchau commented on XALANJ-2113:
---------------------------------------

If an error is detected, perhaps an exception is thrown and caught, the
ErrorListener should be made aware or the error and the exception is
consumed, leaving it to the ErrorListener to decide what to do.
If the error listener only writes to a log file, then that is the
ErrorListener's choice, or it could throw the exception.

If the ErrorListener throws an exception, then that is the exception
that should percolate up.


However this code,
newTransformerHandler 

    } catch( TransformerConfigurationException ex ) { 
      if( m_errorListener != null ) { 
        try { 
          m_errorListener.fatalError( ex ); 
          return null; 
        } catch(TransformerConfigurationException tce) {
           ex = tce;  // just percolate up
        } catch (TransformerException ex1 ) { 
           // wrap 
          ex=new TransformerConfigurationException(ex1); 
        } 
      } 
      throw ex; 
    } 



> Exceptions created but not thrown
> ---------------------------------
>
>          Key: XALANJ-2113
>          URL: http://issues.apache.org/jira/browse/XALANJ-2113
>      Project: XalanJ2
>         Type: Bug
>   Components: transformation
>     Versions: CurrentCVS
>  Environment: win32 xp
>     Reporter: Dave Brosius
>     Assignee: John Gentilin
>     Priority: Minor
>  Attachments: TransFacImpl-patch.txt, XfmrFacImpl-JIRA2113-Patch.txt
>
> Three instances of TranformFactoryImpl's implement the method newXMLFilter.
> In each case these methods create an Exception but do not throw it. It would 
> seem that that was the intent of creating the exception.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to