[ http://issues.apache.org/jira/browse/XALANJ-342?page=all ]
Brian Minchau updated XALANJ-342: --------------------------------- Version: 2.2.0 (was: Latest Development Code) > Code cleanup in TreeWalker2Result.startNode() > --------------------------------------------- > > Key: XALANJ-342 > URL: http://issues.apache.org/jira/browse/XALANJ-342 > Project: XalanJ2 > Type: Bug > Components: transformation, Xalan-interpretive > Versions: 2.2.0 > Environment: Operating System: All > Platform: All > Reporter: Gary L Peskin > Assignee: Xalan Developers Mailing List > Priority: Minor > > Line numbers are with respect to revision 1.11. I've added this item so that > it > can be tracked. I haven't found any errant behavior caused by the current > code. > But it should be cleaned up. > At line 150, we have > if (DTM.ELEMENT_NODE == m_dtm.getNodeType(node)) > this begins an if block. Inside there at line 167, we have > if (DTM.ELEMENT_NODE == m_dtm.getNodeType(node)) > This inner if test just be eliminated and the code left where it is (so that > it > is in the block in which the second if is currently contained). > Second, on line 169 we declare > boolean hasNSDecls = false; > This is later tested but never changed. Shouldn't the body of the loop > at line 174 maybe set this to true? Or should the whole thing be removed? > Gary -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]