[ https://issues.apache.org/jira/browse/XALANJ-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470703 ]
Brian Minchau commented on XALANJ-2358: --------------------------------------- Henry provided these comments so far via some private communication, which I post here: <<<<<<<<<<<<<<<<<<<<<< Hi, Brian. Regarding XALANJ-2358, I have a couple of comments. 1) The copy of the ASF 2.0 license that appears in LICENSE.txt should not include the Appendix. 2) I think it would be easier to read if the text of the licenses were somehow strongly delimited (with a line of equals signs, say). 3) The start of the license text for BCEL is missing - just comment lines, but it looks odd. >>>>>>>>>>>>>>>>>>>>>> I'm going to replace LICENSE.txt which I have attached to this issue with an updated one that addresses these comments. > Clean up Xalan-J 2.7.1 NOTICE/LICENSE > ------------------------------------- > > Key: XALANJ-2358 > URL: https://issues.apache.org/jira/browse/XALANJ-2358 > Project: XalanJ2 > Issue Type: Task > Reporter: Brian Minchau > Assigned To: Brian Minchau > Attachments: java-build.xml.patch1.txt, LICENSE.txt, NOTICE.txt > > > The xalan-j_2_7_1-bin.zip has a top level directory of xalan-j_2_7_1 (this > is OK) > 1) In this directory the Apache NOTICE and LICENSE files are missing. > It is true that in the licenses subdirectory we have xalan.LICENSE.txt with > the right contents, but it is in the wrong directory with a wrong base file > name (same for NOTICE). > 2) For serializer.jar xalan.jar xsltc.jar (if they are packaged) we should > have: > NOTICE.serializer.jar.txt > LICENSE.serializer.jar.txt > LICENSE.xalan.jar.txt > NOTICE.xalan.jar.txt > LICENSE.xstlc.jar.txt > LICENSE.xsltc.jar.txt > (these are already in the liceneses directory with the wrong names). > 3) For other jars we should have NOTICE.<jarname>.txt and > LICENSE.<jarname>.txt where possible > 4) the various readme files should be deleted and any relevant information > should be moved into the corresponding > NOTICE.<jarname>.txt file. For example xalan.README.txt should be deleted, > which contains this: > ----------------------------------------------------- > xalan.jar - Xalan-Java 2 - XSLT Processor. > Source: http://xml.apache.org > See the following files for licenses and attribution notices that apply to > xalan.jar: > licenses/xalan.LICENSE.txt > licenses/xalan.NOTICE.txt > licenses/BCEL.LICENSE.txt > licenses/regexp.LICENSE.txt > licenses/runtime.LICENSE.txt > ----------------------------------------------------- > So lines like these shoud be added to NOTICE.xalan.jar.txt: > ----------------------------------------------------- > See the following files for licenses and attribution notices that apply to > xalan.jar: > LICENSE.bcel.txt > LICENSE.regexp.txt > LICENSE.runtime.txt > NOTICE.serializer.txt > LICENSE.serializer.txt > ----------------------------------------------------- > ... of course in the 2 jar distribution the attribution to regexp and runtime > need not be there. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]