Hello Henry!

Henry Zongaro wrote:
> Looking through the mailing lists from the past few months, I believe
> Joseph Kesselman is the only committer on the Xalan-Java side of things
> who has been responding to questions.

How many months actually? Using gmane, his mail from 2008-02-07 in
XALANJ-2431 seems to be the latest.
http://search.gmane.org/?author=kesselman&group=gmane.text.xml.xalan.devel&sort=date

> In any event I haven't been able to make any time to contribute this
> year, but I will try to make some time in November to review your
> patches.

That is great news, looking forward to it. Since all commits in the past
two yeard were by you, I take your answer as a really good omen. :-)
When you do, sending your review cc'ed directly to me will ensure a
quick reply.

> By doing so, I should revert to active status (or technically,
> this e-mail already causes me to revert to active status, but it doesn't
> really matter, as I won't be able to review your patches for several
> weeks).

There is a large number of patches in JIRA contributed by various other
users. While of course my own patches are most important to me, I guess
there would be quite a lot of reviewing to do to include all the
contributed code. On the other hand, I guess the number of patches in
JIRA is large enough to keep Xalan improving for several releases even
without any real development work on the part of the committers except
reviewing. Do you have any plans with regard to these patches?

I once made an atempt to review a bunch of these, chosen almost at
random. They are included in a bzr branch on launchpad:
https://code.launchpad.net/~gagern/xalan/bugfixes
My review conditions were basically a look ensuring that the code seems
sane at first glance, i.e. at least unlikely to cause regressions, and a
test run ensuring that the gump test suite doesn't break.

If that's enough, then you could commit these as well. If not, then they
would need a second review, where I could perhaps learn how to review
stuff so it becomes acceptable to Xalan. And if you want me to commit
them straight from my bzr branch, then I'd need to become a committer.
Furthermore, if you'd want test cases to accompany the patches, then I'd
first have to understand the different test suites better than I do now.

Greetings,
 Martin von Gagern

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to