[
https://issues.apache.org/jira/browse/XALANJ-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788793#action_12788793
]
Adam Jenkins commented on XALANJ-2510:
--------------------------------------
It's not a case (to be justified and pleaded), and my tone shouldn't matter,
the merit of the argument should...and I think this level of frustration is
quite justified at this point.
Yes, Henry gave criticism (yes constructive)....but stopped short of advice.
So the choice to continue is not mine....you withhold my ability to contribute
by telling me my patch is not good enough, but don't offer advice on where or
how to improve it. So I have no choice.
And yes, Henry has been polite, and has a couple of cases I've acknowledged the
merit on and tried to find a way forward with...I guess there's too
conversations going on here, which can be tricky with issues...one with Henry,
one with Martin. No one is willing to let me know which of the massive amount
of items listed above that my patch apparently fails to address actually need
to be addressed for it to be considered.
And damn sure no one is offering advice on where to start looking or
investigating to make it better.
> Ability to set non tree fragment variable using an extension element (PATCH
> SUPPLIED)
> -------------------------------------------------------------------------------------
>
> Key: XALANJ-2510
> URL: https://issues.apache.org/jira/browse/XALANJ-2510
> Project: XalanJ2
> Issue Type: Improvement
> Security Level: No security risk; visible to anyone(Ordinary problems in
> Xalan projects. Anybody can view the issue.)
> Components: Xalan-extensions
> Affects Versions: The Latest Development Code
> Reporter: Adam Jenkins
> Fix For: The Latest Development Code
>
> Attachments: XALANJ-2510.patch
>
>
> When using extension elements, there is no way to set a non XRTreeFrag
> related variable.
> For example, say you have:
> <xsl:variable name="myvar">
> <my:extension someAttribute="somevalue"/>
> </xsl:variable>
> If my:extension wants to set a tree fragment, string or nodeset into myvar,
> that's not a problem, however if it wants to set a java object, currently
> there is no mechanism for that (any java object passed either returned from
> the method or passed to XSLProcessorContext.outputToResultTree is
> toString()'ed before being passed back to the ElemVariable.getValue() method).
> The proposed change (patch supplied) is to supply an optional variable on
> ElemVariable.java whereby child extension elements can call up to their
> parent and set an XPath to be evaluated after the extension element has
> finished processing.
> This requires only very minor modification to the ElemVariable.getValue
> method to check this variable.
> This also ensures that this is optional functionality and will not affect
> that basic Xalan processing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscr...@xml.apache.org
For additional commands, e-mail: xalan-dev-h...@xml.apache.org
