[
https://issues.apache.org/jira/browse/XALANJ-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12833479#action_12833479
]
Helge Schulz commented on XALANJ-2438:
--------------------------------------
Hello Henry,
I would have wished that you had taken a closer look on the files you have
removed or you had asked me before about the source of their content. The
removed files PredicateInKey-Sun-JRE-1_6_0_18-Fix.jar and
PredicateInKey-Sun-JRE-1_5_0_22-Fix.jar contained only Java source files
(*.jar, *.orig) and compilation results of them (*.class) that are copyrighted
by the Apache Software Foundation and are licensed under the Apache License
2.0. You would have checked this with the following command and resulting
output:
unzip -p PredicateInKey-Sun-JRE-1_6_0_18-Fix.jar *.java *.orig | egrep
"(Copyright)|(Licensed)"
* Copyright 2001-2005 The Apache Software Foundation.
* Licensed under the Apache License, Version 2.0 (the "License");
* Copyright 2001-2005 The Apache Software Foundation.
* Licensed under the Apache License, Version 2.0 (the "License");
* Copyright 2001-2005 The Apache Software Foundation.
* Licensed under the Apache License, Version 2.0 (the "License");
* Copyright 2001-2005 The Apache Software Foundation.
* Licensed under the Apache License, Version 2.0 (the "License");
* Copyright 2001-2005 The Apache Software Foundation.
* Licensed under the Apache License, Version 2.0 (the "License");
* Copyright 2001-2005 The Apache Software Foundation.
* Licensed under the Apache License, Version 2.0 (the "License");
unzip -p PredicateInKey-Sun-JRE-1_5_0_22-Fix.jar *.java *.orig | egrep
"(Copyright)|(Licensed)"
* Copyright 2001-2004 The Apache Software Foundation.
* Licensed under the Apache License, Version 2.0 (the "License");
* Copyright 2001-2004 The Apache Software Foundation.
* Licensed under the Apache License, Version 2.0 (the "License");
* Copyright 2001-2004 The Apache Software Foundation.
* Licensed under the Apache License, Version 2.0 (the "License");
* Copyright 2001-2004 The Apache Software Foundation.
* Licensed under the Apache License, Version 2.0 (the "License");
* Copyright 2001-2004 The Apache Software Foundation.
* Licensed under the Apache License, Version 2.0 (the "License");
* Copyright 2001-2004 The Apache Software Foundation.
* Licensed under the Apache License, Version 2.0 (the "License");
I have extracted the original Version of theses source files (*.orig) from the
'src.zip' file of the corresponding Sun JDK distribution. These files contain
an unmodified Apache copyright header. Additional Sun confirms in the
'THIRDPARTYLICENSEREADME.txt' file in the used JDK/JRE distributions, that
Xalan J2 in the JDK/JRE is governed by the terms of the Apache 2.0 license.
Here is the quote:
"The following software may be included in this product: Xalan J2; Use of any
of this
software is governed by the terms of the license below:
Apache License
Version 2.0, January 2004
http://www.apache.org/licenses/
..."
I have submitted my patch also under Apache 2.0 license, so in my understanding
the removed files have contained only material governed by the Apache 2.0
license.
I understand that the command output above, do not prove the authenticity of
the files. I would like to suggest, that I will contact PMC chair David Bertoni
directly how we can prove (in example with the assistance of an Apache lawyer),
that the questioned files contain only Apache 2.0 licensed material.
Until this issue is resolved, I will upload a new version of my test case,
without any Apache 2.0 licensed material from Sun sources as you requested
To the best of my knowledge Sun has never modified the three files, I have
modified to fix the JDK/JRE version, since they copied Xalan-J in the
'com.sun.org.apache.internal' package and start to distribute them in every
JDK/JRE version. Therefore the original files are identical accept of the
package name with old versions in the Xalan-J version control system. Even if
Sun would have modified these files, they would have publish these changes
under Apache 2.0 license by using an unmodified Apache copyright header and
confirming the license inside their third party software statement. So in my
understanding, every Xalan-J enhancement inside an JDK/JRE distribution can be
added to the Apache Xalan-J version. But this is a subject for a discussion at
another place.
Henry Zongaro wrote at 12/Feb/10 02:01 PM:
>
> Now that I understand that you have accessed the Sun reference implementation
> of JAXP,
> I won't be able to review and apply your patches. That's because there's a
> risk that some
> of the changes you have contributed or might contribute in the future are
> covered by
> Sun's copyright. As I am not an employee of Sun or Oracle, I don't have the
> authority to
> contribute Sun copyright code to the Apache project. Only an employee of Sun
> or Oracle
> who has signed an Apache CLA can contribute such code.
As I explained above, I did not use any JAXP material for developing the
Xalan-J patch (only Apache 2.0 material). I only contribute my patch to the
JAXP project, because for me the Xalan-J project seems to be dead after waiting
nearly two years for a review and receiving no answers for dozens of mails. The
contribution for the JAXP project was an advice from the Xalan-J PMC (ex- ?)
member Santiago Pericas-Geertsen to expedite the bug fixing in JDK/JRE (see his
xalan-dev posting from 2010-01-26, archived at
<http://mail-archives.apache.org/mod_mbox/xml-xalan-dev/201001.mbox/browser>).
Does Henry's statement above mean, that I am no longer welcome to contribute
any patches to Xalan-J by following Santiagos advice or does it mean, that only
an Oracle employe and PMC member can check in my patch (Who)?
If I am no longer welcome, I would have made a big mistake and what would have
then been the correct way to contribute a patch to Xalan-J and JDK (over JAXP,
which is the only source for XML updates) simultaneously?
Did you or any Apache member receive a request from Oracle/Sun to remove the
discussed files?
Regards, Helge
--
Helge Schulz - http://OpenSHORE.org
> [PATCH] XSLTC ignores XPath predicates in xsl:key elements
> ----------------------------------------------------------
>
> Key: XALANJ-2438
> URL: https://issues.apache.org/jira/browse/XALANJ-2438
> Project: XalanJ2
> Issue Type: Bug
> Components: XSLTC
> Affects Versions: The Latest Development Code
> Environment: Linux and Windows XP with Sun JRE 1.5.0_14, 1.5.0_15,
> 1.6.0_04 and 1.6.0_05
> Reporter: Helge Schulz
> Priority: Blocker
> Fix For: The Latest Development Code
>
> Attachments: PredicateInKey-Xalan-SVN-r889881.patch,
> PredicateInKey-XSLT-Test-1.1.jar, PredicateInKey-XSLT-Test-1.2.jar,
> PredicateInKey-XSLT-Test-1.3.jar, PredicateInKey-XSLT-Test.jar,
> PredicateInKey.out, PredicateInKey.xml, PredicateInKey.xsl
>
>
> The Xalan XSLT compiler (XSLTC) ignores XPath predicates in xsl:key
> elements since the class 'org.apache.xalan.xsltc.compiler.Stylesheet'
> was rearranged in august 2003 to reorder the compilation of top level
> XSLT elements (including keys) to respect dependencies between global
> XSLT variables and keys. Method 'compileTopLevel' was changed to emit
> code also for key elements and not emit code calling the method generated
> by 'compileBuildKeys'. For this reason the byte code for each key element
> is generated twice: First time into generated method 'buildKeys' from
> 'compileBuildKeys' and second time into generated method 'topLevel'
> from 'compileTopLevel'. Method 'buildKeys' is still necessary, because
> it is called by the XSLT 'document' function, if additional input
> documents are loaded later.
> Unfortunately the translate method of some XPath elements expected to
> be called only once and they remove sub elements while their first execution.
> So all XPath predicates get lost in class
> 'org.apache.xalan.xsltc.compiler.FilterExpr'
> and 'org.apache.xalan.xsltc.compiler.Step' by a remove operation on
> the '_predicates' container while the execution from 'compileBuildKeys'.
> So 'compileTopLevel' generates wrong code for all key elements containing
> predicates in their XPath expressions.
> The attached patch changes the 'FilterExpr' and 'Step' class to use an
> index variable to determine the current predicate and to not remove them.
> This patch was tested with the current Subversion version of Xalan
> (last change of Xalan tree in revision 584164) and with Sun JDK 1.5.0_14,
> 1.5.0_15, 1.6.0_04 and 1.6.0_05.
> This bug exists also in Sun JRE 1.6 (1.6.0 up to 1.6.0_05) and JRE 1.5
> (since 1.5.0_12 up to 1.5.0_15) in classes
> 'com.sun.org.apache.xalan.internal.xsltc.compiler.FilterExpr' and
> 'com.sun.org.apache.xalan.internal.xsltc.compiler.Step'. The attached
> test JAR file contains also patches for these versions and fixes in form
> of JAR files to be installed into '../jre/lib/endorsed' directories of
> Sun JRE installations. The last Sun JRE version with correct handling
> of xls:key elements is 1.5.0_11.
> Please add the attached test files to the Xalan test suite. I have
> released them under Apache license version 2.0.
> Helge Schulz - OpenSHORE.org
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscr...@xml.apache.org
For additional commands, e-mail: xalan-dev-h...@xml.apache.org
