Hi Steven, These all look sensible to me but I am in a similar position to you - I don't know the code that well. It seems that the docs are wrong though (you can def pass a null in) so if you think the same then I would say change them.
Gareth On 18 Apr 2012, at 04:01, Steve Hathaway wrote: > Xalan Team: > I would like confirmation from another team member that the JavaDoc > edits identified by SHIN HWEI TAN make sense. > > https://issues.apache.org/jira/browse/XALANJ-2553 > https://issues.apache.org/jira/browse/XALANJ-2554 > https://issues.apache.org/jira/browse/XALANJ-2555 > https://issues.apache.org/jira/browse/XALANJ-2556 > > I don't know enough about the XALAN-J internals to comment, > but I can make the edits and commit the changes to correct > the API JavaDoc documentation. > > After the JavaDoc modifications are made to the sources, I can create > another set of web pages on my committer's site for review. > > Sincerely, > Steven J. Hathaway > Xalan Documentation Project > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: xalan-dev-unsubscr...@xml.apache.org > For additional commands, e-mail: xalan-dev-h...@xml.apache.org > > -- Gareth Reakes, CTO WE7 - Great Music, Free +44-20-7117-0809 http://www.we7.com “The music business is a cruel and shallow money trench, a long plastic hallway where thieves and pimps run free, and good men die like dogs. There's also a negative side. “ - Hunter S. Thompson