[ 
https://issues.apache.org/jira/browse/XALANJ-2546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291442#comment-13291442
 ] 

Gary D. Gregory commented on XALANJ-2546:
-----------------------------------------

Thank you for the example test. I've ported these to the Xalan test framework 
as:

{noformat}
commit -m "Test XALANJ-2546 xsl:sort lang attribute ignores parameter value, 
only hard-coding works...." -N (13 paths specified)
    Adding         
C:/svn/org/apache/xalan/test/tests/conf/sort/sort-alphabet-english.param
    Adding         
C:/svn/org/apache/xalan/test/tests/conf/sort/sort-alphabet-english.xml
    Adding         
C:/svn/org/apache/xalan/test/tests/conf/sort/sort-alphabet-english.xsl
    Adding         
C:/svn/org/apache/xalan/test/tests/conf/sort/sort-alphabet-polish.param
    Adding         
C:/svn/org/apache/xalan/test/tests/conf/sort/sort-alphabet-polish.xml
    Adding         
C:/svn/org/apache/xalan/test/tests/conf/sort/sort-alphabet-polish.xsl
    Adding         
C:/svn/org/apache/xalan/test/tests/conf/sort/sort-alphabet-russian.param
    Adding         
C:/svn/org/apache/xalan/test/tests/conf/sort/sort-alphabet-russian.xml
    Adding         
C:/svn/org/apache/xalan/test/tests/conf/sort/sort-alphabet-russian.xsl
    Sending        C:/svn/org/apache/xalan/test/tests/conf-gold
    Adding         
C:/svn/org/apache/xalan/test/tests/conf-gold/sort/sort-alphabet-english.out
    Adding         
C:/svn/org/apache/xalan/test/tests/conf-gold/sort/sort-alphabet-polish.out
    Adding         
C:/svn/org/apache/xalan/test/tests/conf-gold/sort/sort-alphabet-russian.out
    Transmitting file data ...
    Committed revision 1347840.{noformat}

See the param files for instructions.

To see the tests pass for TRAX:

Run org.apache.qetest.xsl.StylesheetTestletDriver -goldDir tests/conf-gold 
-param.lang ru 

To see the same tests fail for XSLTC:

Run org.apache.qetest.xsl.StylesheetTestletDriver -goldDir tests/conf-gold 
-param.lang ru -flavor xsltc

Make sure you have the "output" directory on the classpath.

Looking at {{org.apache.xalan.xsltc.compiler.Sort}}, it seems clear that _lang 
is not coded right because it is not a {{AttributeValue}}.

The attached patch fixes that BUT does not fix the issue. The behavior appears 
unchanged.

This requires more digging or help from others.

It would be interesting to know if XSLTC can deal with /any/ input parameters 
or if this is isolated to the sort class.

                
> xsl:sort lang attribute ignores parameter value, only hard-coding works
> -----------------------------------------------------------------------
>
>                 Key: XALANJ-2546
>                 URL: https://issues.apache.org/jira/browse/XALANJ-2546
>             Project: XalanJ2
>          Issue Type: Bug
>      Security Level: No security risk; visible to anyone(Ordinary problems in 
> Xalan projects.  Anybody can view the issue.) 
>          Components: Xalan
>    Affects Versions: 2.7.1
>         Environment: java version "1.6.0_20", Xalan 2.7.1
>            Reporter: Don Smith
>         Attachments: XALANJ-2546.diff, sorting-example.zip
>
>
> I have an XSL stylesheet that uses xsl:sort for a list of names. I added the 
> lang attribute to the sort, using a variable passed to the stylesheet for its 
> value:   lang="{$locale}". When sorting a list of Russian names, the ordering 
> is incorrect. I can see that the parameter value is present and correct in 
> the stylesheet as it executes by using an xsl:message statement. When I 
> hard-code the value of lang to ru (lang="ru"), the sort works correctly. This 
> defect  cause improper sorting in Russian and Polish, a defect in our 
> application.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscr...@xml.apache.org
For additional commands, e-mail: xalan-dev-h...@xml.apache.org

Reply via email to