[
https://issues.apache.org/jira/browse/XAP-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Gennaco updated XAP-354:
------------------------------
Description:
This patch will include changes which should address both
http://issues.apache.org/jira/browse/XAP-72
and
http://issues.apache.org/jira/browse/XAP-43
The problem with the children of collapsed rows showing up within the table was
caused by faulty logic in the insertRow function in xap.widgets.dojo.TableRow,
which should set its child rows to be invisible when it is collapsed.
Additional problems arose when addressing this in this manner, including the
rows still taking up space, which is addressed by removing the call to
getPeer().show() in DojoWidgetBridge.init(), which caused display:none to be
removed from the style of widgets, regardless of whether or not they were
supposed to be "visible".
Note: In the TreeTable code, there was a TODO indicating that rows should be
collapsed in their initial state, and that onFirstExpand should be fired as an
event, I changed the initial state to collapsed and updated the TODO as
appropriate in the included file.
This caused tables in tab panes to not render correctly, since the tab panes
hide their children when a tab is not showing, and is addressed by code in
TreeTable to have tables do an initial layout when they are first show on
screen.
To get tables which are initially hidden to render correctly when they are made
visible (visible attribute set to "true") the setVisibleAttribute() function
from AbstractWidgetBridge was overridden to use dojo's show() and hide()
functions as appropriate.
Additional problems addressed in these files:
The column layout for IE was not working when sorting, column headers in
treetables in my test page were growing and getting out of synch with their
corresponding row cells, this was due to invalid widths (using the trailing
"px") being provided to dojo.html.setMarginBox, which caused weird table layout
problems.
The tbody property in the TreeTable was being held when it was no longer valid,
this caused exceptions when attempts to access the it.
was:
This patch will include changes which should address both
http://issues.apache.org/jira/browse/XAP-72
and
http://issues.apache.org/jira/browse/XAP-43
The problem with the children of collapsed rows showing up within the table was
caused by faulty logic in the insertRow function in xap.widgets.dojo.TableRow,
which should set its child rows to be invisible when it is collapsed.
Additional problems arose when addressing this in this manner, including the
rows still taking up space, which is addressed by removing the call to
getPeer().show() in DojoWidgetBridge.init(), which caused display:none to be
removed from the style of widgets, regardless of whether or not they were
supposed to be "visible".
This caused tables in tab panes to not render correctly, since the tab panes
hide their children when a tab is not showing, and is addressed by code in
TreeTable to have tables do an initial layout when they are first show on
screen.
To get tables which are initially hidden to render correctly when they are made
visible (visible attribute set to "true") the setVisibleAttribute() function
from AbstractWidgetBridge was overridden to use dojo's show() and hide()
functions as appropriate.
Additional problems addressed in these files:
The column layout for IE was not working when sorting, column headers in
treetables in my test page were growing and getting out of synch with their
corresponding row cells, this was due to invalid widths (using the trailing
"px") being provided to dojo.html.setMarginBox, which caused weird table layout
problems.
The tbody property in the TreeTable was being held when it was no longer valid,
this caused exceptions when attempts to access the it.
> TreeTable rendering improvements
> --------------------------------
>
> Key: XAP-354
> URL: https://issues.apache.org/jira/browse/XAP-354
> Project: XAP
> Issue Type: Improvement
> Components: Widgets: Table/Tree/TreeTable
> Reporter: David Gennaco
> Attachments: DojoWidgetBridge.js, TreeTable.js, treetable.xal
>
>
> This patch will include changes which should address both
> http://issues.apache.org/jira/browse/XAP-72
> and
> http://issues.apache.org/jira/browse/XAP-43
> The problem with the children of collapsed rows showing up within the table
> was caused by faulty logic in the insertRow function in
> xap.widgets.dojo.TableRow, which should set its child rows to be invisible
> when it is collapsed. Additional problems arose when addressing this in this
> manner, including the rows still taking up space, which is addressed by
> removing the call to getPeer().show() in DojoWidgetBridge.init(), which
> caused display:none to be removed from the style of widgets, regardless of
> whether or not they were supposed to be "visible".
> Note: In the TreeTable code, there was a TODO indicating that rows should be
> collapsed in their initial state, and that onFirstExpand should be fired as
> an event, I changed the initial state to collapsed and updated the TODO as
> appropriate in the included file.
> This caused tables in tab panes to not render correctly, since the tab panes
> hide their children when a tab is not showing, and is addressed by code in
> TreeTable to have tables do an initial layout when they are first show on
> screen.
> To get tables which are initially hidden to render correctly when they are
> made visible (visible attribute set to "true") the setVisibleAttribute()
> function from AbstractWidgetBridge was overridden to use dojo's show() and
> hide() functions as appropriate.
> Additional problems addressed in these files:
> The column layout for IE was not working when sorting, column headers in
> treetables in my test page were growing and getting out of synch with their
> corresponding row cells, this was due to invalid widths (using the trailing
> "px") being provided to dojo.html.setMarginBox, which caused weird table
> layout problems.
> The tbody property in the TreeTable was being held when it was no longer
> valid, this caused exceptions when attempts to access the it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
