Hi all, Found the messages disappearing into my spam folder... and fixed that :)
*interface.c:* Yes that should probably have been a separate PR - I'm relatively new to git so I'll see if I can manage to change that. *<<8 vs *256:* For int types the compiler will (at least should) optimize *256 into <<8 making it no slower. The reason for the change is that the type of the variable changes to double, so <<8 is no longer possible. I may have to have another go at 3 printf calls that I changed (%i -> %1.2f). It's probably easiest to change them back to %i and cast the args to match. *Copyright:* Yes, they were copied. Suggestions adopted. *IM vs GM* I'm no expert on IM or GM but I found deprecation info for IM 6.7 that supports the function substitutions I made (compiling with 6.9 here). http://patrickdieudonne.com/ImageMagick-6.7.0-2/www/api/deprecate.html GM has only deprecated GetPixels() and GetIndexes() from version 1.3.28 (Jan 2018), so that's not urgent. I didn't find any info on what GM is replacing it with, but IM7 replaces it yet again :( For now I have modified the #if directives to only apply the changes where GraphicsMagick is not in use. That should get it to compile, and once we have a plan for how to handle this I'll hunt down the remaining GetIndexes() calls that haven't been replaced yet. Mike Curt Mills, WE7U wrote on 11/07/18 05:08: > > A few more things (all minor stuff): > > * > > Changes to interface.c have nothing to do with the main reason for > the PR. Would be better to do a separate PR for it so it's not > hidden in the big patch. > > * > > Changing from "<< 8" to "* 256"" is slower. I suggest keeping the > "<< 8" code in the map*.c files. > > * > > The headers on the two new files appear to have been copied from > an existing file. They need Copyright dates updated at least. > Should be only "Copyright (C) 2018 The Xastir Group" since they > are new files. "dlm.h" says: "contributed by Jerry Dunmire, > KA6HLD." which needs to be corrected as well. "dlm.c" has an $Id: > message which is wrong, plus also has "This file derived from" > message at the bottom of the header. Correct? Should be deleted? > > I'm looking forward to trying this out when the GM stuff gets fixed! > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/Xastir/Xastir/pull/40#issuecomment-403966364>, or > mute the thread > <https://github.com/notifications/unsubscribe-auth/AaQZuqr5l-9jJplRf2XuQAifbIPa73Mwks5uFRexgaJpZM4VG9hD>. > _______________________________________________ Xastir-dev mailing list [email protected] http://xastir.org/mailman/listinfo/xastir-dev
