You're quite right. This has been in the code since festival support for ID speech was introduced in 2002, in commit 374e8cf34. The error even survived a sort of refactor of the original style of reading the config file in 2005, with commit f0c9a3db.
I just pushed this minor change. Thank you for your efforts in finding the mistake. On Wed, Nov 07, 2018 at 08:38:13PM -0500, we recorded a bogon-computron collision of the <[email protected]> flavor, containing: > I was looking through the code trying to figure out why the > File->Configure->Speech->New Station button wasn't saved from one > session to the next. In the process of looking at that issue, I > noticed a variable called festival_speak_ID. I'm not clear on how this > is set or used, but the code in file xa_config.c on line 2418 looks wrong. > > > 2409 #ifdef HAVE_FESTIVAL > 2410 /* Festival Speech defaults */ > 2411 festival_speak_new_station = get_int > ("SPEAK_NEW_STATION",0,1,0); > 2412 festival_speak_proximity_alert = get_int > ("SPEAK_PROXIMITY_ALERT",0,1,0); > 2413 festival_speak_tracked_proximity_alert = get_int > ("SPEAK_TRACKED_ALERT",0,1,0); > 2414 festival_speak_band_opening = get_int > ("SPEAK_BAND_OPENING",0,1,0); > 2415 festival_speak_new_message_alert = get_int > ("SPEAK_MESSAGE_ALERT",0,1,0); > 2416 festival_speak_new_message_body = get_int > ("SPEAK_MESSAGE_BODY",0,1,0); > 2417 festival_speak_new_weather_alert = get_int > ("SPEAK_WEATHER_ALERT",0,1,0); > 2418 festival_speak_new_station = get_int ("SPEAK_ID",0,1,0); > 2419 #endif // HAVE_FESTIVAL > > The last line of the above looks to be a copy and paste error. The > correct expression should probably be: > > festival_speak_ID = get_int ("SPEAK_ID",0,1,0); > > Changing this line fixed my issue, and it is likely the fix for some > other unknown issue as well. > > > -Mike > > _______________________________________________ > Xastir-dev mailing list > [email protected] > http://xastir.org/mailman/listinfo/xastir-dev -- Tom Russo KM5VY Tijeras, NM echo "prpv_a'rfg_cnf_har_cvcr" | sed -e 's/_/ /g' | tr [a-m][n-z] [n-z][a-m] _______________________________________________ Xastir-dev mailing list [email protected] http://xastir.org/mailman/listinfo/xastir-dev
