On Fri, Apr 19, 2019 at 10:18:23AM -0700, we recorded a bogon-computron collision of the <[email protected]> flavor, containing: > Jason Godfrey asked me this type of question and I answered as best I > could, but I'd like Tom Russo's opinion so we know how to do things going > forward: > > Should ALL Git commit's happen to our own fork, then we always do a pull > request? > > If it's something simple like what I just did, is committing directly to > the main repo ok?
I've been doing both. If it's something I think I should get other people's opinion on, I make a PR. If it's something so trivial as cleaning up comments or unused variables, I don't. But I really like the PR way of doing business, and think we should use it when it's adding value. And it often does. > This is only an issue for those with commit privileges on the main repo, > currently three of us. However the answer may be of interest to more people > since many participate in more than one project and may have commit access > elsewhere. For community input, fork-and-pull-request is the only way to go, IMHO. For substantive input from people with push access, we should be looking over each others' shoulders and using PRs to get that input. But I hate to make a general rule one way or another. -- Tom Russo KM5VY Tijeras, NM echo "prpv_a'rfg_cnf_har_cvcr" | sed -e 's/_/ /g' | tr [a-m][n-z] [n-z][a-m] _______________________________________________ Xastir-dev mailing list [email protected] http://xastir.org/mailman/listinfo/xastir-dev
