On Fri, Apr 19, 2019 at 01:55:26PM -0600, we recorded a bogon-computron collision of the <[email protected]> flavor, containing: > On Fri, Apr 19, 2019 at 02:42:38PM -0500, we recorded a bogon-computron > collision of the <[email protected]> flavor, containing: > > Would it make sense to create a ticket for each file and then those tickets > > to track who is doing work on each file? > > That's a whole lotta tickets. There are over 100 .c and .h files to pick > through. And almost every one has *some* warning or other in it.
Rather than open a ton of tickets, we can just open lots of PRs to pick away at the already open ticket #24. I submitted PR #64 just now, cleaning up a small handful of files (all of rtree, alert.c, datum.c, db.c, and a couple of irritating warnings in igate.c and interface.c). I'm using the newly-instituted Travis-CI setup (thank you, Jason G.) to get the cross-platform building done, and verifying that my changes aren't creating more warnings. PR #64 is a good start. If anyone else cares to attack the issue of warnings, they could hack on the code and submit a PR that mentions issue #24, and we can use Travis to verify that warnings are going away. Travis is currently set up to build on Ubuntu 14.04 with GCC and OS X with Clang. I can test code changes in these PRs with gcc 8 manually. > We could instead break it up into clumps of a few files per ticket instead. > Picking files with first letter [a-d], [e-h], [i-l], [m-p], [q-t], and [u-z] > makes a set of files around 12-20 per clump. > > > Macs use clang as "gcc". I might be able to help cleanup some files but I > > might not see the same set of warning as a gcc 8 user. > > My BSD machine can build Xastir with clang, but then I'm forced to use > ImageMagick (the GraphicsMagick port apparently forces use of GCC proper, > for some busted reason related to openmp, I think). I was building > with clang for a while when I hadn't noticed that they broke GraphicsMagick > in this way, and configure was quietly picking up ImageMagick for me instead. > And clang also whined about a lot of things, but not always the same things. > > > On Fri, Apr 19, 2019 at 2:37 PM km5vy Tom Russo <[email protected]> wrote: > > > > > Unfortunately, turning off warnings is a bad idea in this case. Some of > > > the > > > things it's warning about are really errors, such as misuse of snprintf > > > (extremely common in Xastir), using "sizeof" on a pointer to get the size > > > of > > > the object pointed to by the object (in quite a number of places), and so > > > forth. > > > > > > If we tell GCC to shut up, we miss those errors. > > > > > > There are, of course, a number of these warnings that are just annoyance. > > > For example, it is very common in Xastir for us to use something like > > > strncat > > > or snprintf very deliberatly to cause the copy operation to truncate the > > > source down into the size of the destination. GCC8 warns us that the > > > operation > > > could cause truncation, because the destination is smaller than the > > > source. > > > > > > But there are many, many more, and some are real errors. > > > > > > On Fri, Apr 19, 2019 at 12:31:43PM -0700, we recorded a bogon-computron > > > collision of the <[email protected]> flavor, containing: > > > > On Fri, Apr 19, 2019 at 11:30 AM Tom Russo <[email protected]> wrote: > > > > > > > > > > > > > > If we want to release again after we stabilize a little, I'd be OK > > > with it, > > > > > but I really doubt I'll be able to get the warning issue in hand > > > anytime > > > > > this > > > > > month. Unless, perhaps, someone would like to join in the fun and we > > > could > > > > > divide up the work. > > > > > > > > > > > > > I might be able to help a little here and there. I can remember doing > > > > the > > > > same thing way back when a couple of times (I'm coming up on 20 years on > > > > this one project!). At more than one point in the project I had it down > > > to > > > > zero errors/warnings. Then another GCC version came out each time. > > > > > > > > One thing we could also perhaps do is change the compile flags to issue > > > > fewer warnings, but of course wouldn't want to turn off ones that are > > > real > > > > and might have implications if we don't correct our code. Don't want to > > > > hide real problems. > > > > > > > > -- > > > > Curt, WE7U http://we7u.wetnet.net > > > http://www.sarguydigital.com > > > > > > -- > > > Tom Russo KM5VY > > > Tijeras, NM > > > > > > echo "prpv_a'rfg_cnf_har_cvcr" | sed -e 's/_/ /g' | tr [a-m][n-z] > > > [n-z][a-m] > > > > > > _______________________________________________ > > > Xastir-dev mailing list > > > [email protected] > > > http://xastir.org/mailman/listinfo/xastir-dev > > > > > > > > > -- > > "The problem with quotes on the Internet is that it is often difficult to > > verify their authenticity." - *Abraham Lincoln* > > -- > Tom Russo KM5VY > Tijeras, NM > > echo "prpv_a'rfg_cnf_har_cvcr" | sed -e 's/_/ /g' | tr [a-m][n-z] [n-z][a-m] -- Tom Russo KM5VY Tijeras, NM echo "prpv_a'rfg_cnf_har_cvcr" | sed -e 's/_/ /g' | tr [a-m][n-z] [n-z][a-m] _______________________________________________ Xastir-dev mailing list [email protected] http://xastir.org/mailman/listinfo/xastir-dev
