The pom changes for the most part simply remove localized configuration in child modules to support 1.5, since all modules build with 1.5 they can share the same config from the top-level pom.

--jason


On Mar 23, 2007, at 9:44 PM, Dain Sundstrom wrote:

The java code looks good to me.  I didn't read the pom changes.

-dain

On Mar 23, 2007, at 9:31 PM, Jason Dillon wrote:

Does anyone want to review/comment on this patch? Or shall I just commit it?

--jason


On Mar 21, 2007, at 3:50 PM, Jason Dillon wrote:

Patch here for review:

    http://issues.apache.org/jira/browse/XBEAN-85

This does not include retrotranslator stuff... though if we wanted to add that it would consist of adding this to top-level pom in project/build/plugins:

----8<----
<plugin>
    <groupId>org.codehaus.mojo</groupId>
    <artifactId>retrotranslator-maven-plugin</artifactId>
    <executions>
        <execution>
            <goals>
                <goal>translate-project</goal>
            </goals>
            <configuration>
                <classifier>jdk14</classifier>
                <attach>true</attach>
            </configuration>
        </execution>
    </executions>
</plugin>
---->8----

Lemme know if you guys are cool with this, and I will apply it... though I'd like to know why the xbean-finder tests are throwing OOME too... as well as why xbean-log4j was included in modules, but missing in src.

Cheers,

--jason


On Mar 21, 2007, at 1:30 AM, James Strachan wrote:

+1

On 3/21/07, Guillaume Nodet <[EMAIL PROTECTED]> wrote:
+1

On 3/21/07, Jason Dillon <[EMAIL PROTECTED]> wrote:
>
> Looks like xbean-naming is still compiling for 1.4. Is there any > specific reason for this? Can we switch all of xbean to compile for > 1.5... and if you need 1.4 compat, then use the retrotranslator-maven-
> plugin's translate-project goal to make jdk14 artifacts?
>
> --jason
>
>
> On Mar 20, 2007, at 5:14 AM, David Jencks wrote:
>
> > geronimo-naming jar
> >
> > I think you'll find you need to update xbean-naming.
> >
> > thanks
> > david jencks
> > On Mar 20, 2007, at 4:03 AM, Jason Dillon wrote:
> >
> >> The server/trunk build is picking this up in configs/rmi- naming...
> >> but from where?
> >>
> >> Need to update this to use java.util.concurrent... its using
> >> backport-concurrent-util at the moment.
> >>
> >> --jason
> >
>
>


--
Cheers,
Guillaume Nodet
------------------------
Architect, LogicBlaze (http://www.logicblaze.com/)
Blog: http://gnodet.blogspot.com/



--

James
-------
http://radio.weblogs.com/0112098/




Reply via email to