[ 
https://issues.apache.org/jira/browse/XBEAN-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14003494#comment-14003494
 ] 

Guillaume Nodet commented on XBEAN-266:
---------------------------------------

I think there's still some problems.
My understand is the following:
  * xbean-asm5-shaded provides org.apache.xbean.asm5 + 
org.apache.xbean.asm5.original.commons 
  * xbean-asm-util provides org.apache.xbean.asm5.original.commons but is not a 
bundle
  * xbean-finder uses the org.objectweb.asm packages + 
org.apache.xbean.asm5.original.commons
  * xbean-finder-shaded uses the org.apache.xbean.asm5 packages + 
org.apache.xbean.asm5.original.commons
  * xbean-reflect can use both org.apache.xbean.asm5 and org.objectweb.asm 
packages, but requires at least one of them, and also needs 
org.apache.xbean.asm5.original.commons

IIUC, the use of the shaded packages is mostly for non osgi environments, where 
multiple asm versions may coexist in incompatible versions.  However, in OSGi, 
the import version ranges protects against such use case, so the use of the 
shaded versions is not really interesting.
The main problems is caused by the fact that 
org.apache.xbean.asm5.original.commons is only provide by the xbean-asm5-shaded 
bundle.

Hence, I wonder if it would make more sense to remove 
org.apache.xbean.asm5.original.commons from xbean-asm5-shaded and embed it in 
xbean-finder and xbean-reflect.
  

> xbean-reflect embeds asm5 even in not shaded version
> ----------------------------------------------------
>
>                 Key: XBEAN-266
>                 URL: https://issues.apache.org/jira/browse/XBEAN-266
>             Project: XBean
>          Issue Type: Bug
>    Affects Versions: 3.17
>            Reporter: Romain Manni-Bucau
>         Attachments: XBEAN-reflect-osgi-01.patch, XBEAN-reflect.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to