On Sat, Aug 23, 2014 at 3:22 AM, Aurimas Vinckevicius
<aurimas....@gmail.com> wrote:
> * Certainly +1 for some sort of "busy" indicator. I would say a disabled
> (gray) "Validate" button with a spinning circle.

We could use one of these: http://msurguy.github.io/ladda-bootstrap/

> * The context that it displays for errors is a bit awkward. E.g.
> (bibliography is misspelled here)
>>
>>  ayout>
>>    </biblography>
>>  </styl
>
> I think it should be displaying the full preceding and following lines
> instead of chopping them off.

These code snippets are what validator.nu returns in its validation
report. I guess we could extract the full preceding and following
lines from the full XML document, but that's a bit of work.

> * Would be neat if it could also inform if there are unused macros

Funny you should ask. I actually wrote a Schematron rule yesterday
evening to check for these
(https://gist.github.com/rmzelle/573df55275a606c20aa0). Turns out
there are a little over 700 unused macros in the repository:
https://gist.github.com/rmzelle/fc0f6a4538746c39e6d1

As an aside, I wonder whether we should mark CSL styles that define
unused macros as invalid in the next version of CSL. As an argument
against doing so, unused macros aren't problematic for CSL processors,
just a waste of space. Maybe we should just have Travis CI and our
validator test for them, but still allow them per the CSL schema.

> * How about having it tidy up the formatting as well? E.g. fix indents (both
> amount of indenting and spaces instead of tabs), spacing before />, etc.

I think this would only work if we could tidy up the XML before
submitting it to validator.nu. Otherwise I don't know how to do handle
the line highlighting (since tidying can move the XML code around).
Are you aware of any online tidiers that offer a REST API, or a js
library that does XML tidying?

> * Would be awesome if you could directly create a pull request against some
> style in the repo (e.g. have a field where you could fill in the file name
> [with suggestions as you type, of course] for an existing style and then
> click a button to create request. A drop-down with all styles might be a bit
> too much to handle). I think that might be related to what Carles had in
> mind with the link generation.

I'm not following. What would the workflow be, exactly? You mean
create a pull request from within the validator, once a style passes
validation?

We certainly should consider whether this validator can be extended to
streamline the submission process. Sebastian and I do a lot of
hand-holding to get contributors to follow
https://github.com/citation-style-language/styles/wiki/Style-Requirements,
and it should be possible to automate some of this.

Rintze

------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
xbiblio-devel mailing list
xbiblio-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xbiblio-devel

Reply via email to