It is unneeded at this stage. Eventually, we'll be reading back responses from
the web server and was going to need the lib then.
I removed the bad import in the addon.xml and the new revision is
6ad85e8d167ce925d6b2
Thanks for the help. It's my first xbmc plugin.
-Sean
On Oct 8, 2010, at 2:06 PM, Zeljko Ametovic wrote:
> Hi Sean,
>
> just one more check before I pull,
>
> you have removed json from utitlties.py, was that intentional? <import
> addon="script.module.simplejson" version="2.0.9"/> is then not needed. it is
> in the wrong place anyway, it should be as below:
>
> <requires>
> <import addon="xbmc.python" version="1.0"/>
> <import addon="script.module.simplejson" version="2.0.9"/>
> </requires>
>
> Cheers,
> Zeljko
>
>
>
>
>
>
>
> On Fri, Oct 8, 2010 at 9:36 PM, sean <[email protected]> wrote:
> Thanks Zeljko,
>
> All issues listed are fixed and tested. Everything is the same as the
> original pull info, except the revision is now 3e88952e3c877a752cb5.
>
> Let me know if there is anything else.
>
> Thanks,
> Sean
>
>
> On Oct 8, 2010, at 9:25 AM, Zeljko Ametovic wrote:
>
>> Hi,
>>
>> before we pull, few things will need your attention:
>>
>> • please rename license.txt to LICENCE.txt for consistency with other
>> scripts.
>> • icon must have a solid background and be size 256x256 ,
>> http://wiki.xbmc.org/index.php?title=Addons_for_XBMC#Guidlines_for_images
>> • we have a simplejson module(script.module.simplejson), add <import
>> addon="script.module.simplejson" version="2.0.9"/> to addon.xml and get rid
>> of the simplejson folder.
>> • default.tbn is not used any more, please remove it
>>
>> once done, please send new pull request.
>>
>> Cheers,
>> Zeljko
>>
>>
>> On Fri, Oct 8, 2010 at 8:04 AM, sean <[email protected]> wrote:
>> *addon - script.trakt
>> *version - 0.0.4
>>
>>
>> *url - git://github.com/rudf0rd/Trakt.git
>> *revision - 15fe99bb8464e05a6128a14ad37c29c9b8277504
>> *branch - addon_format
>> *xbmc version - dharma
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Beautiful is writing same markup. Internet Explorer 9 supports
>> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
>> Spend less time writing and rewriting code and more time creating great
>> experiences on the web. Be a part of the beta today.
>> http://p.sf.net/sfu/beautyoftheweb
>> _______________________________________________
>> Xbmc-addons mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>>
>>
>
>
------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
Spend less time writing and rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
