Hi Vago,
Thanks, some comments:
- there is an additional language on git (PL iirc), please add it to your
addon.xml
- sratim.xml contains "Includes" and "GetSettings" section which doesn't
needed any more in the addons structure. Also the header tags are including
tags which are now defined in the addon.xml. Please remove these.
- you set common.imdb scraper library as a dependency in addon.xml but you
don't use it (you could for trailers by the way... see e.g how imdb scraper
is calling the common library for trailer function).
- Please change the way you call tmdb for fanarts (to "chain function" -
see again e.g how imdb scraper is doing it)
- Please add a LICENCE.txt file to the folder (you can copy it from other
scrapers)
- There is a removed setting for IMDb ranking. If you want to remove this
function, please remove the setting completely, because it doesn't look good
on the GUI
Cheers,
Bence
On Sat, Oct 9, 2010 at 3:05 AM, Guy Vago's gmail <[email protected]> wrote:
> Hi,
>
> This is a fixed dharma version of the sratim scraper.
>
> Thanks,
> Vago
>
>
> ------------------------------------------------------------------------------
> Beautiful is writing same markup. Internet Explorer 9 supports
> standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
> Spend less time writing and rewriting code and more time creating great
> experiences on the web. Be a part of the beta today.
> http://p.sf.net/sfu/beautyoftheweb
> _______________________________________________
> Xbmc-addons mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>
>
------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
Spend less time writing and rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
